Add recommended workaround for broken carthage on Xcode 12

Author: thiagohmcruz

repository_rules/framework_builder.bzl

@@ -101,12 +101,30 @@ def build_carthage_frameworks(
         verbose: if true, it will show the output of running carthage in the command line
     """
 
+    # Workaround for carthage failing on Xcode 12
+    # https://github.com/Carthage/Carthage/blob/master/Documentation/Xcode12Workaround.md
+    #
+    carthage_xc12_workaround = """
+        xcconfig=$(mktemp /tmp/static.xcconfig.XXXXXX)
+        trap 'rm -f "$xcconfig"' INT TERM HUP EXIT
+
+        # For Xcode 12 make sure EXCLUDED_ARCHS is set to arm architectures otherwise
+        # the build will fail on lipo due to duplicate architectures.
+
+        CURRENT_XCODE_VERSION=$(xcodebuild -version | grep "Build version" | cut -d' ' -f3)
+        echo "EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200__BUILD_$CURRENT_XCODE_VERSION = arm64 arm64e armv7 armv7s armv6 armv8" >> $xcconfig
+
+        echo 'EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200 = $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_simulator__NATIVE_ARCH_64_BIT_x86_64__XCODE_1200__BUILD_$(XCODE_PRODUCT_BUILD_VERSION))' >> $xcconfig
+        echo 'EXCLUDED_ARCHS = $(inherited) $(EXCLUDED_ARCHS__EFFECTIVE_PLATFORM_SUFFIX_$(EFFECTIVE_PLATFORM_SUFFIX)__NATIVE_ARCH_64_BIT_$(NATIVE_ARCH_64_BIT)__XCODE_$(XCODE_VERSION_MAJOR))' >> $xcconfig
+
+        export XCODE_XCCONFIG_FILE="$xcconfig"
+    """
     _prebuilt_frameworks_importer(
         implementation = _carthage_impl,
         name = name,
         directory = directory,
         files = files,
-        cmd = cmd % (carthage_version, git_repository_url),
+        cmd = (carthage_xc12_workaround + cmd) % (carthage_version, git_repository_url),
         timeout = timeout,
         verbose = verbose,
     )

tests/ios/unit-test/test-imports-app/BUILD.bazel

@@ -20,7 +20,10 @@ ios_application(
         "main.m",
     ],
     bundle_id = "com.example.TestImports-App",
-    families = ["ipad"],
+    families = [
+        "ipad",
+        "iphone",
+    ],
     minimum_os_version = "12.0",
     module_name = "TestImports_App",
     resource_bundles = {"ResourceBundle": glob(

tests/ios/xcodeproj/Test-Imports-App-Project.xcodeproj/project.pbxproj

@@ -396,7 +396,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = "com.example.TestImports-App";
 				PRODUCT_NAME = "TestImports-App";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "\"$(inherited)\"";
-				TARGETED_DEVICE_FAMILY = 2;
+				TARGETED_DEVICE_FAMILY = "2,1";
 			};
 			name = Release;
 		};
@@ -421,7 +421,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = "com.example.TestImports-App";
 				PRODUCT_NAME = "TestImports-App";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "\"$(inherited)\"";
-				TARGETED_DEVICE_FAMILY = 2;
+				TARGETED_DEVICE_FAMILY = "2,1";
 			};
 			name = Debug;
 		};

tests/macos/xcodeproj/Test-Target-With-Test-Host-Project.xcodeproj/project.pbxproj

@@ -463,7 +463,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = "com.example.TestImports-App";
 				PRODUCT_NAME = "TestImports-App";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "\"$(inherited)\"";
-				TARGETED_DEVICE_FAMILY = 2;
+				TARGETED_DEVICE_FAMILY = "2,1";
 			};
 			name = Debug;
 		};
@@ -536,7 +536,7 @@
 				PRODUCT_BUNDLE_IDENTIFIER = "com.example.TestImports-App";
 				PRODUCT_NAME = "TestImports-App";
 				SWIFT_ACTIVE_COMPILATION_CONDITIONS = "\"$(inherited)\"";
-				TARGETED_DEVICE_FAMILY = 2;
+				TARGETED_DEVICE_FAMILY = "2,1";
 			};
 			name = Release;
 		};