Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.2.2 Registration is running. #22

Open
roywill opened this issue Jul 25, 2024 · 2 comments
Open

2.1.2.2 Registration is running. #22

roywill opened this issue Jul 25, 2024 · 2 comments
Assignees

Comments

@roywill
Copy link

roywill commented Jul 25, 2024

The key returned in the example is the identifier of the payload or the signed statement as they are the same HASH. If it is the payload, this precludes simultaneously registering two signed statements simultaneously. I suspect you really want to supply a transaction token not reference anything about the signed statement nor the payload.

If it is truly the receipt, then assuming the HASH can be computed of the final receipt seems a cart before horse statement.

@JAG-UK
Copy link
Contributor

JAG-UK commented Jul 26, 2024

Agreed that name scheme doesn't work. There are a couple of different problems here:

  • the collision risk identified remains a problem for durable identifiers for Receipts or registered Signed Statements. We need to tackle that separately
  • for the identifier returned in a 'registration is running' case, we need to return an ID for the operation against which the client polls. Attention should be given to properties of this ID such as surviving pod crashes.

We implemented this for the 120 hackathon, I'll put up a R and the group can comment.

@JAG-UK JAG-UK self-assigned this Aug 6, 2024
@JAG-UK
Copy link
Contributor

JAG-UK commented Aug 9, 2024

In my PR for Issue #23 I changed 'receipt' to 'identifier' which opens the door to fixing this. Probably needs more explanation but don't want to change this until we've had the discussion on PR #27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants