Additional tests to check flexibility options of thermal house and storage #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l storage and house above target temp
…se below target temp
…ouse # Conflicts: # CHANGELOG.md
…ouse # Conflicts: # CHANGELOG.md
…ouse # Conflicts: # CHANGELOG.md
…ouse # Conflicts: # CHANGELOG.md
…ouse # Conflicts: # CHANGELOG.md
jo-bao
reviewed
Aug 13, 2024
| isRunning = false, | ||
| 0, | ||
| Some(hpData.ambientTemperature), | ||
| Kilowatts(0.0), |
There was a problem hiding this comment.
Why is the expression changed from the double value?
There was a problem hiding this comment.
If you refer to the case lefthand where the lastHouseState was 21°C and 80 Kilowatts feedin, this one should still be in the table (labeled Storage and house have remaining capacity)
src/test/scala/edu/ie3/simona/model/participant/HpModelSpec.scala
Outdated
Show resolved
Hide resolved
sebastian-peter
requested changes
Aug 15, 2024
src/test/scala/edu/ie3/simona/model/participant/HpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/HpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/HpModelSpec.scala
Outdated
Show resolved
Hide resolved
src/test/scala/edu/ie3/simona/model/participant/HpModelSpec.scala
Outdated
Show resolved
Hide resolved
This reverts commit f279b89.
include suggestion from reviewer Co-authored-by: Sebastian Peter <[email protected]>
…-house' into df/#729-additional-tests-thermal-house
This was referenced Aug 21, 2024
Signed-off-by: Sebastian Peter <[email protected]>
sebastian-peter
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #729