Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return type Try for NewtonRaphsonPF#calculate #9

Open
ckittl opened this issue Nov 19, 2021 · 0 comments
Open

Return type Try for NewtonRaphsonPF#calculate #9

ckittl opened this issue Nov 19, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Milestone
Version 2.0

Comments

@ckittl
Copy link
Member

ckittl commented Nov 19, 2021

powerflow/src/main/scala/edu/ie3/powerflow/NewtonRaphsonPF.scala

Lines 95 to 98 in 63ab0e2

def calculate(
operationPointUnordered: Array[PresetData],
initData: Option[StartData] = None
): PowerFlowResult = {

Currently, only a PowerFlowResult is given back. However, if something unexpected does occur and an exception happens, this is not covered and the calling code crashes directly.
@ckittl ckittl added enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right labels Nov 19, 2021
@ckittl ckittl added this to the Version 2.0 milestone Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Milestone
Version 2.0
Development

No branches or pull requests
1 participant
@ckittl