Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether FactoryData and subclasses can be eliminated #976

Open
sebastian-peter opened this issue Jan 3, 2024 · 3 comments
Open

Check whether FactoryData and subclasses can be eliminated #976

sebastian-peter opened this issue Jan 3, 2024 · 3 comments
Assignees
Labels
code quality Code readability or structure is improved

Comments

@sebastian-peter
Copy link
Member

As another successive issue of #969, there might be a way to eliminate FactoryData and all its subclasses (EntityData etc.) by creating AssetInputs and similar entities directly.
To make this work, the new constructors in the form of AssetInputEntityData(EntityData entityData, OperatorInput operator) (but of course adapted for AssetInputs) could be used to iteratively create Inputs from the simplest UniqueEntity to the desired input type.

A side effect of this would be that error messages would be easier to create, since there is no way of ensuring that a FactoryData also includes UUID and id.

@sebastian-peter sebastian-peter added the code quality Code readability or structure is improved label Jan 3, 2024
@staudtMarius staudtMarius self-assigned this Mar 13, 2024
@staudtMarius
Copy link
Member

@sebastian-peter To do this we'd have to change classes like AssetInput and UniqueInput from being abstract. This should be done after #1044.

@sebastian-peter
Copy link
Member Author

@sebastian-peter To do this we'd have to change classes like AssetInput and UniqueInput from being abstract. This should be done after #1044.

Yes, and I'm not really sure if that'd be smart. We should think this through beforehand.

@staudtMarius
Copy link
Member

@sebastian-peter If you want, we could talk about this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Code readability or structure is improved
Projects
None yet
Development

No branches or pull requests

2 participants