Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly handle not receiving any weather data from the weather source #554

Open
t-ober opened this issue Mar 2, 2022 · 2 comments
Open
Labels
bug Something isn't working

Comments

@t-ober
Copy link
Contributor

t-ober commented Mar 2, 2022

Currently we get a division by zero error later down the road when not receiving any weather values from the weather Source. We should throw an exception before explicitly stating that there we did not find any weather data!

@t-ober t-ober added good first issue Good for newcomers code quality Code readability or structure is improved labels Mar 2, 2022
@t-ober t-ober added this to the Version 3.1 milestone Mar 2, 2022
@sebastian-peter sebastian-peter removed the code quality Code readability or structure is improved label Jul 28, 2022
@sebastian-peter sebastian-peter modified the milestones: Version 3.1, Version 4.0, Version 4.1 Jul 25, 2023
@sebastian-peter sebastian-peter modified the milestones: Version 4.1, Version 4.2 Nov 2, 2023
@sebastian-peter sebastian-peter added bug Something isn't working and removed good first issue Good for newcomers labels Dec 13, 2023
@staudtMarius
Copy link
Member

staudtMarius commented Feb 2, 2024

I think this could be partially resolved with #999. After this PR an exception is thrown if we cannot read the csv weather or csv coordinate source correctly.

@sebastian-peter sebastian-peter modified the milestones: Version 4.2, Version 5.0 Feb 12, 2024
@sebastian-peter
Copy link
Member

I think this could be partially resolved with #999. After this PR an exception is thrown if we cannot read the csv weather or csv coordinate source correctly.

Yes, but we're still not checking if no data is returned at all - although this might be more the responsibility of SIMONA

@sebastian-peter sebastian-peter removed this from the Version 5.0 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants