Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IllegalArgumentException caused by historic data for ways #422

Open
danielfeismann opened this issue Apr 30, 2024 · 1 comment · May be fixed by #423
Open

IllegalArgumentException caused by historic data for ways #422

danielfeismann opened this issue Apr 30, 2024 · 1 comment · May be fixed by #423
Labels
bug Something isn't working
Milestone
Version 1.0

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Apr 30, 2024 •
edited
Loading 

15:58:15.739 ERROR e.i.osmogrid.guardian.run.RunSupport - Node 268847628 of Way 24737158 is not within our nodes mapping
java.lang.IllegalArgumentException: Node 268847628 of Way 24737158 is not within our nodes mapping
	at utils.OsmoGridUtils$.$anonfun$buildStreetGraph$2(OsmoGridUtils.scala:126)
	at utils.OsmoGridUtils$.$anonfun$buildStreetGraph$2$adapted(OsmoGridUtils.scala:113)
	at scala.collection.IterableOnceOps.foreach(IterableOnce.scala:619)
	at scala.collection.IterableOnceOps.foreach$(IterableOnce.scala:617)
	at scala.collection.AbstractIterator.foreach(Iterator.scala:1303)
	at utils.OsmoGridUtils$.$anonfun$buildStreetGraph$1(OsmoGridUtils.scala:113)
	at utils.OsmoGridUtils$.$anonfun$buildStreetGraph$1$adapted(OsmoGridUtils.scala:111)
	at scala.collection.immutable.VectorStatics$.foreachRec(Vector.scala:2124)
	at scala.collection.immutable.Vector.foreach(Vector.scala:2130)
	at utils.OsmoGridUtils$.buildStreetGraph(OsmoGridUtils.scala:111)
	at edu.ie3.osmogrid.lv.LvCoordinator$.$anonfun$awaitResults$1(LvCoordinator.scala:244)
	at org.apache.pekko.actor.typed.internal.BehaviorImpl$ReceiveBehavior.receive(BehaviorImpl.scala:146)
	at org.apache.pekko.actor.typed.Behavior$.interpret(Behavior.scala:283)
	at org.apache.pekko.actor.typed.Behavior$.interpretMessage(Behavior.scala:239)
	at org.apache.pekko.actor.typed.internal.adapter.ActorAdapter.handleMessage(ActorAdapter.scala:141)
	at org.apache.pekko.actor.typed.internal.adapter.ActorAdapter.aroundReceive(ActorAdapter.scala:117)
	at org.apache.pekko.actor.ActorCell.receiveMessage(ActorCell.scala:590)
	at org.apache.pekko.actor.ActorCell.invoke(ActorCell.scala:557)
	at org.apache.pekko.dispatch.Mailbox.processMailbox(Mailbox.scala:280)
	at org.apache.pekko.dispatch.Mailbox.run(Mailbox.scala:241)
	at org.apache.pekko.dispatch.Mailbox.exec(Mailbox.scala:253)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

Only hypothesis, needs to be checked: This may be caused by bounderies that are only partly in the pbf-File and thus couldn't be of type ClosedWay.

Edit: Reason is historic data for ways.
@danielfeismann danielfeismann changed the title IllegalArgumentException probably caused by bounderies that aren' IllegalArgumentException probably caused by bounderies that aren't of type ClosedWay Apr 30, 2024
@danielfeismann danielfeismann added the bug Something isn't working label Apr 30, 2024
@danielfeismann danielfeismann added this to the Version 1.0 milestone Apr 30, 2024
@danielfeismann danielfeismann mentioned this issue Apr 30, 2024
Closed
@danielfeismann
Copy link
Member Author

Reason for this exception lies in being all versions, also from the past, of the way are considered. See osm history

<osm version="0.6" generator="CGImap 0.9.2 (2785514 spike-07.openstreetmap.org)" copyright="OpenStreetMap and contributors" attribution="http://www.openstreetmap.org/copyright" license="http://opendatacommons.org/licenses/odbl/1-0/">
<way id="486458680" visible="true" version="1" changeset="47708870" timestamp="2017-04-12T21:04:23Z" user="herisusa" uid="107703">
<nd ref="268847063"/>
<nd ref="268847628"/>
<nd ref="268847629"/>
<nd ref="268847630"/>
<nd ref="268847631"/>
<nd ref="268847632"/>
<nd ref="268847633"/>
<nd ref="271199701"/>
<nd ref="4790734805"/>
<tag k="highway" v="unclassified"/>
</way>
<way id="486458680" visible="true" version="2" changeset="102048016" timestamp="2021-03-31T10:32:20Z" user="flohoff" uid="34927">
<nd ref="268847063"/>
<nd ref="268847630"/>
<nd ref="268847631"/>
<nd ref="268847632"/>
<nd ref="268847633"/>
<nd ref="271199701"/>
<nd ref="4790734805"/>
<tag k="highway" v="unclassified"/>
</way>
</osm>

requires changes in PSU as well: PSU#466

@danielfeismann danielfeismann changed the title IllegalArgumentException probably caused by bounderies that aren't of type ClosedWay IllegalArgumentException caused by historic data for ways Apr 30, 2024
@danielfeismann danielfeismann linked a pull request Apr 30, 2024 that will close this issue
Open
danielfeismann added a commit that referenced this issue May 7, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into df/#422-exception-caused-by-histor…
1530f1d 
…ic-data
danielfeismann added a commit that referenced this issue May 7, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into df/#422-exception-caused-by-histor…
4bac2fb 
…ic-data
danielfeismann added a commit that referenced this issue May 8, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into df/#422-exception-caused-by-histor…
a8f5466 
…ic-data
danielfeismann added a commit that referenced this issue May 14, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into df/#422-exception-caused-by-histor…
eb9ce56 
…ic-data
danielfeismann added a commit that referenced this issue May 21, 2024
@danielfeismann
Merge branch 'refs/heads/dev' into df/#422-exception-caused-by-histor…
eb89255 
…ic-data

# Conflicts:
#	src/main/scala/edu/ie3/osmogrid/lv/LvGridGeneratorSupport.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Version 1.0
Development

Successfully merging a pull request may close this issue.

IllegalArgumentException caused by historic data for ways ie3-institute/OSMoGrid
1 participant
@danielfeismann