IllegalArgumentException caused by historic data for ways #423
Conversation
| entities.filter { | ||
| case entity: E if entity.metaInformation.isDefined => | ||
| entity.metaInformation.exists(_.version.contains(maxVersion)) | ||
| case _ => true | ||
| } |
There was a problem hiding this comment.
Does this work if we have two versions of the same entity one with metaInformation and one without?
I think in this case, both versions are returned, which could cause problems. Maybe you could add a test for this case.
There was a problem hiding this comment.
Good point! I changed this into a logger warning and filter out these entities.
There was a problem hiding this comment.
What happens if we have an entity that occures only once but have no metaInformation? Will it be filtered out too? I think this could cause a porblem when generating grids?
Maybe you could count the occurences of all enitity ids and only use this filter for those entites that have multiple occurences.
There was a problem hiding this comment.
As far as I checked there is always a version at the entity. So imho this is very unlikely. But sure we can split the entities and filter only those with multiple occurences. :)
There was a problem hiding this comment.
Ok, there are of course options to exclude the metainformation. Maybe we should think about to make them mandatory. Will discuss this tomorrow within the sprint :)
There was a problem hiding this comment.
@danielfeismann Do you have an update on this part?
There was a problem hiding this comment.
Honestly, OSM data that includes multiple versions of the same entity is just broken to me. I'd be fine with just assuming that the OSM data we're handling is coherent. Do we really need the meta information then?
There was a problem hiding this comment.
I agree with you, @sebastian-peter. Tried it again by using overpass, worked well at that location. So I'm fine with closing this one.
…ic-data # Conflicts: # src/main/scala/edu/ie3/osmogrid/lv/LvGridGeneratorSupport.scala
resolves #422