Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract configuration strings in separate method #220

Open
t-ober opened this issue Aug 5, 2022 · 0 comments
Open

Extract configuration strings in separate method #220

t-ober opened this issue Aug 5, 2022 · 0 comments
Labels
refactoring Refactoring concerning code style, organization etc.

Comments

@t-ober
Copy link
Contributor

t-ober commented Aug 5, 2022

Currently we parse configurations in test the following way:

          """input.osm.pbf.file = "pbf_file"
            |input.asset.file.directory = "asset_input_dir"
            |input.asset.file.separator = ","
            |input.asset.file.hierarchic = false
            |output.csv.directory = "output_file_path"
            |output.gridName = "test_grid"
            |""".stripMargin

in a lot of places. Extract that into a method returning a correct configuration string and use str.replace to change the part in e.g. ConfigFailFast tests

@t-ober t-ober added the refactoring Refactoring concerning code style, organization etc. label Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring concerning code style, organization etc.
Projects
None yet
Development

No branches or pull requests

1 participant