Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: rework CI workflows #7

Merged
merged 5 commits into from
Jul 22, 2024
Merged

ci: rework CI workflows #7

merged 5 commits into from
Jul 22, 2024

Conversation

Yannick-Dayer
Copy link
Contributor

@Yannick-Dayer Yannick-Dayer commented Jul 18, 2024

  • Changed the file names to follow the same naming as clapper;
  • Added features from clapper's workflows:
    • try packaging the project during the test workflow;
    • release on GitHub will now contain the packaged distributables;
  • Removed the generation of unused coverage reports (junit and xml).

📚 Documentation preview 📚: https://gridtk--7.org.readthedocs.build/en/7/

Adds a packaging step in tests, publish binaries to gitlab on a release,
changed the file name to be uniform with other projects.
junit was used by GitLab to parse the output. The coverage reports are
now generated by a GitHub action from "raw" .coverage files.
Copy link

github-actions bot commented Jul 18, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/gridtk
  __main__.py
  cli.py
  manager.py
  models.py
Project Total  

This report was generated by python-coverage-comment-action

@Yannick-Dayer
Copy link
Contributor Author

@183amir I did not add the matrix of tests for different versions of Python.
If you think it could be useful to have it, I will gladly set it up.

183amir
183amir previously approved these changes Jul 18, 2024
Copy link
Collaborator

@183amir 183amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@183amir
Copy link
Collaborator

183amir commented Jul 18, 2024

Actually, can you remove codql too?

@183amir
Copy link
Collaborator

183amir commented Jul 18, 2024

@183amir I did not add the matrix of tests for different versions of Python. If you think it could be useful to have it, I will gladly set it up.

yes, please add those too

Test the project against each minor python version in GitHub Actions.
@Yannick-Dayer
Copy link
Contributor Author

I added a test for each supported version of python.

Do you think it would make sense to also add tests on macos? (Or would some tests not work on that environment?)

@183amir 183amir changed the title Rework CI workflows ci: rework CI workflows Jul 19, 2024
Copy link
Collaborator

@183amir 183amir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM. I don't think we need to test on macos. But maybe you want add windows tests for clapper and auto-intersphinx

@183amir 183amir merged commit e35c1c8 into main Jul 22, 2024
10 checks passed
@183amir 183amir deleted the ci/workflows branch July 22, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants