Skip to content

Commit 0a1b13f

Browse files
Wang, Jian Jlgao4
authored andcommitted
CryptoPkg/OpensslLib: fix VS2017 build failure
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1878 This issue is specific to VS2017 which tries to resolve symbol referenced by a symbol not really referenced eventually. ossl_init_load_crypto_strings -> err_load_crypto_strings_int (not really referenced) -> ERR_load_OSSL_STORE_strings Because OPENSSL_NO_ERR and OPENSSL_NO_AUTOERRINIT are not defined by default, err_load_crypto_strings_int() will not be actually referenced by ossl_init_load_crypto_strings(). Since err_load_crypto_strings_int() is not actually referenced at all, the fix can be done simply by removing crypto/err/err_all.c from build. Cc: Dandan Bi <[email protected]> Cc: Xiaoyu Lu <[email protected]> Signed-off-by: Jian J Wang <[email protected]> Reviewed-by: Liming Gao <[email protected]>
1 parent cbfdc1b commit 0a1b13f

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

CryptoPkg/Library/OpensslLib/OpensslLib.inf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@
218218
$(OPENSSL_PATH)/crypto/dso/dso_win32.c
219219
$(OPENSSL_PATH)/crypto/ebcdic.c
220220
$(OPENSSL_PATH)/crypto/err/err.c
221-
$(OPENSSL_PATH)/crypto/err/err_all.c
222221
$(OPENSSL_PATH)/crypto/err/err_prn.c
223222
$(OPENSSL_PATH)/crypto/evp/bio_b64.c
224223
$(OPENSSL_PATH)/crypto/evp/bio_enc.c

CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,6 @@
218218
$(OPENSSL_PATH)/crypto/dso/dso_win32.c
219219
$(OPENSSL_PATH)/crypto/ebcdic.c
220220
$(OPENSSL_PATH)/crypto/err/err.c
221-
$(OPENSSL_PATH)/crypto/err/err_all.c
222221
$(OPENSSL_PATH)/crypto/err/err_prn.c
223222
$(OPENSSL_PATH)/crypto/evp/bio_b64.c
224223
$(OPENSSL_PATH)/crypto/evp/bio_enc.c

0 commit comments

Comments
 (0)