Update Android SDK Target to v32 (Android 12); request MANAGE_EXTERNAL_STORAGE #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeage
requested review from
andybak and
mikeskydev
and removed request for
andybak
|
This will also unblock #524 |
11 tasks
|
I might unlink #503 as while it is technically 'solved', it might be the cleaner solution once such APIs are properly available on Quest, and MANAGE doesn't work if we wanted to upload to Play store. |
Fair. We can always make it a conditional. Also, it says "may be closed", so I don't know if it actually closes automatically or not. |
…ion.HasUserAuthorizedPermission
mikeskydev
approved these changes
Nov 24, 2023
helifax
added a commit
to LearnHub/open-brush
that referenced
this pull request
Jun 3, 2024
…_EXTERNAL_STORAGE (icosa-foundation#563)" This reverts commit 1433142.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quest submissions now require a target SDK level of 32. We need to use the new storage APIs, however, this is inaccessible on the Quest devices for a variety of reasons, as discussed extensively on Discord. For now, use the file-manager permission of MANAGE_EXTERNAL_STORAGE where available (ignore it if it's not; that probably means a device with an older Android runtime that doesn't need this any way).
Note that on the Q2, after approving the MANAGE_EXTERNAL_STORAGE permission in the (2D) settings app, the Oculus menu bar remains open, although OB loads in the background. To return to our app, the user needs to click on the OB icon and then choose "Resume". This is not the best UX, but it's out of our hands.