You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I feel like we should probably have some best practices set up for accepting pull requests.
On the Tilt Brush team, we used gerrit to do code reviews of all code before it went in, but there was no expectation that the person who did the review would test the code live, partly because code was only coming from other team members, and we had a shared understanding of the level of testing required before commit, and we all knew what each other was working on, etc.
I'm assuming that we won't just accept any pull request that comes in, which poses the question - how do we decide which ones do make it?
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I feel like we should probably have some best practices set up for accepting pull requests.
On the Tilt Brush team, we used gerrit to do code reviews of all code before it went in, but there was no expectation that the person who did the review would test the code live, partly because code was only coming from other team members, and we had a shared understanding of the level of testing required before commit, and we all knew what each other was working on, etc.
I'm assuming that we won't just accept any pull request that comes in, which poses the question - how do we decide which ones do make it?
Beta Was this translation helpful? Give feedback.
All reactions