From b9cd0116d57e291422b6e7a48cd6f8d0d291ad8f Mon Sep 17 00:00:00 2001 From: Mike Miller <87874+mikeage@users.noreply.github.com> Date: Wed, 11 Dec 2024 09:09:04 +0200 Subject: [PATCH] Do not use # in PR build names (#796) * Remove # from the productName, if set (affects save path) * Remove # from the 'description' --- .github/workflows/build.yml | 2 +- Assets/Editor/BuildTiltBrush.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3234056239..d588c0dd13 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -146,7 +146,7 @@ jobs: else if [[ ${{ github.ref }} == refs/pull/* ]] then - DESCRIPTION="PR#$(echo ${{ github.ref }} | sed -e 's#refs/pull/##' -e 's#/merge##')" + DESCRIPTION="PR$(echo ${{ github.ref }} | sed -e 's#refs/pull/##' -e 's#/merge##')" elif [[ ${{ github.ref }} == refs/heads/* ]] then DESCRIPTION="$(echo ${{ github.ref }} | sed -e 's#refs/heads/##')" diff --git a/Assets/Editor/BuildTiltBrush.cs b/Assets/Editor/BuildTiltBrush.cs index 259ba578b2..a8af77a93d 100644 --- a/Assets/Editor/BuildTiltBrush.cs +++ b/Assets/Editor/BuildTiltBrush.cs @@ -1032,7 +1032,7 @@ public TempSetAppNames(BuildTarget target, string Description) #endif if (!String.IsNullOrEmpty(Description)) { - new_name += "-(" + Description + ")"; + new_name += "-(" + Description.Replace("#", "") + ")"; new_identifier += "-" + Description.Replace("_", "").Replace("#", "").Replace("-", ""); } if (m_IsAndroidOrIos)