Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS support #2

Open
LordRembo opened this issue Apr 29, 2011 · 3 comments
Open

iOS support #2

LordRembo opened this issue Apr 29, 2011 · 3 comments
Assignees

Comments

@LordRembo
Copy link

Not sure if this is just the jQuery port of the MooTools version as well, but videosub seems to break the video on iOS (tested on iPhone and iPad in iOS 4.3). All I see is a black rectangle.

@ghost ghost assigned makenosound May 14, 2011
@makenosound
Copy link
Member

Strange. I've had it working fine on some iOS devices. I'll do some further testing and see what's going on.

@khomel
Copy link

khomel commented Apr 19, 2012

I found this plugin today and it works like a charm on Safari on the desktop. On iPad I'm finding it breaking the video as well. Any idea what might be happening? I've been trying to tear it apart with no luck.

@elika
Copy link

elika commented Dec 27, 2012

I have the same problem with Safari on iPad (iOs 5.1.1). It seems like there is a problem with the $this.wrap() call.

I have substituted the lines:

container = $('<div class="' + o.containerClass + '">');
container = $this.wrap(container).parent();

with

container = $this.parent();

and now it works as expected.

The effect of this change is that the there is no div wrapped around the video tag and the subtitles bar is added to the existent video tag parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants