Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI to the model #17

Open
ibrahimsharaf opened this issue Mar 29, 2019 · 4 comments
Open

Add CLI to the model #17

ibrahimsharaf opened this issue Mar 29, 2019 · 4 comments

Comments

@ibrahimsharaf
Copy link
Owner

Add CLI support for the following commands:

  • Pass a dataset to the model for training
  • Pass a dataset to the model for testing given a trained model path
  • Pass a dataset to the model which splits it for training then testing
  • Pass a single sentence to the model for prediction given a trained model path

Depends on #14

@dheerajgattupalli
Copy link

dheerajgattupalli commented Oct 20, 2019

Hi, I am interested in helping out with this issue ... I already made some progress and made the CLI for training, testing and single sentence prediction with python fire module ... I just wanted to clarify about the train test split requirement exactly ... you are expecting it to be saving the complete data after the train test split into files and loading them back for repeatability because that's already being taken care of by random state parameter ... so if you can add some info to the exact requirement for train test split separately would be helpful...

Thank You.

@ibrahimsharaf
Copy link
Owner Author

Hi @dheerajgattupalli, thanks for your collaboration, there's no need to save the train/test data into separate files on disk.

@dheerajgattupalli
Copy link

So what should that command do?

@ibrahimsharaf
Copy link
Owner Author

ibrahimsharaf commented Oct 21, 2019

It would take a dataset path, read it into pandas dataframe, then split it to train/test using sklearn train_test_split method, use the training data to train doc2vec then classifier, use the testing data to test the trained classifier, report back the accuracy metrics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants