Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom plate sticking out for 5-column manuform #112

Open
mbugert opened this issue May 18, 2022 · 1 comment · May be fixed by #110
Open

Bottom plate sticking out for 5-column manuform #112

mbugert opened this issue May 18, 2022 · 1 comment · May be fixed by #110

Comments

@mbugert
Copy link

mbugert commented May 18, 2022

With the default configuration settings (5 columns), the manuform bottom plate contains a rectangular section next to the pinky column which does not line up with the case above:
broken

The cause is this cube operation:

dactyl-keyboard/src/dactyl_keyboard/manuform.clj

Line 1633 in a97ded5

(cube 50 50 5))))

mbugert added a commit to mbugert/ibnuda-dactyl-keyboard that referenced this issue May 18, 2022
@mbugert
Simplify manuform plate generation with more 2D ops
dea4f21 
Bottom plate generation in manuform.clj relied on several hacky 3D
operations (micro-translations before projection operations and
extruded screw hole shapes). This is replaced with 2D operations
followed by a single linear_extrude. This commit also fixes the
non-aligning bottom plate mentioned in ibnuda#112.
@mbugert mbugert linked a pull request May 18, 2022 that will close this issue
Open
@mbugert
Copy link
Author

mbugert commented May 18, 2022

After the fix in #110:
fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify code for screw placement mbugert/ibnuda-dactyl-keyboard
1 participant
@mbugert