Skip to content

Commit 2832a6f

Browse files
committed
Support attach-point in addition to data-attach-point, fixes #175.
1 parent c501771 commit 2832a6f

File tree

4 files changed

+24
-3
lines changed

4 files changed

+24
-3
lines changed

delite/createRenderer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,8 @@ define([
5555
template._instanceData = this.instanceData;
5656
}
5757
this.own(template.instantiate(this).insertBefore(this))[0].content;
58-
forEach.call(this.querySelectorAll("[data-attach-point]"), function (elem) {
59-
var value = elem.getAttribute("data-attach-point");
58+
forEach.call(this.querySelectorAll("[attach-point],[data-attach-point]"), function (elem) {
59+
var value = elem.getAttribute("attach-point") || elem.getAttribute("data-attach-point");
6060
if (value) {
6161
this[value] = elem;
6262
}

tests/delite/createRenderer.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ define([
2020
"../../delite/createRenderer!./templates/nestedWidgetTemplate.html",
2121
"../../delite/createRenderer!./templates/complexAttributeTemplate.html",
2222
"../../delite/createRenderer!./templates/attachPointTemplate.html",
23+
"../../delite/createRenderer!./templates/dataAttachPointTemplate.html",
2324
"../../delite/createRenderer!./templates/simpleWithAlternateBindingTemplate.html",
2425
"../../delite/createRenderer!../templates/eventTemplate.html",
2526
"deliteful/StarRating",
@@ -47,6 +48,7 @@ define([
4748
renderNestedWidgetTemplate,
4849
renderComplexAttributeTemplate,
4950
renderAttachPointTemplate,
51+
renderDataAttachPointTemplate,
5052
renderAlternateBindingTemplate,
5153
renderEventsTemplate
5254
) {
@@ -91,6 +93,10 @@ define([
9193
render: renderAttachPointTemplate,
9294
baseClass: "liaison-test-attachpoint"
9395
}),
96+
DataAttachPointTemplateWidget = register("liaison-test-dataattachpoint", [HTMLElement, Widget], {
97+
render: renderDataAttachPointTemplate,
98+
baseClass: "liaison-test-dataattachpoint"
99+
}),
94100
AlternateBindingTemplateWidget = register("liaison-test-alternatebinding", [HTMLElement, Widget], {
95101
render: renderAlternateBindingTemplate,
96102
baseClass: "liaison-test-alternatebinding",
@@ -523,6 +529,20 @@ define([
523529
expect(w.valueNode).to.equal(w.querySelector("input"));
524530
});
525531
});
532+
it("Attach point with alternate attribute name", function () {
533+
var w = new DataAttachPointTemplateWidget().placeAt(document.body);
534+
this.timeout = 10000;
535+
handles.push({
536+
remove: function () {
537+
w.destroy();
538+
}
539+
});
540+
return waitFor(function () {
541+
return w.valueNode;
542+
}).then(function () {
543+
expect(w.valueNode).to.equal(w.querySelector("input"));
544+
});
545+
});
526546
it("Simple binding with default alternate binding factory", function () {
527547
var w = new AlternateBindingTemplateWidget({
528548
first: "John"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
<input data-attach-point="valueNode">
1+
<input attach-point="valueNode">
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
<input data-attach-point="valueNode">

0 commit comments

Comments
 (0)