fix(sqlite): create a single table from Python object

Author: mesejo

ibis/backends/sqlite/__init__.py

@@ -485,9 +485,11 @@ def create_table(
         if schema is not None:
             schema = ibis.schema(schema)
 
+        in_memory = False
         if obj is not None:
             if not isinstance(obj, ir.Expr):
                 obj = ibis.memtable(obj)
+                in_memory = True
 
             self._run_pre_execute_hooks(obj)
 
@@ -503,43 +505,49 @@ def create_table(
             else:
                 database = "temp"
 
+        quoted = self.compiler.quoted
+        dialect = self.dialect
+
         if overwrite:
             created_table = sg.table(
                 util.gen_name(f"{self.name}_table"),
                 catalog=database,
-                quoted=self.compiler.quoted,
+                quoted=quoted,
             )
-            table = sg.table(name, catalog=database, quoted=self.compiler.quoted)
+            table = sg.table(name, catalog=database, quoted=quoted)
         else:
-            created_table = table = sg.table(
-                name, catalog=database, quoted=self.compiler.quoted
-            )
+            created_table = table = sg.table(name, catalog=database, quoted=quoted)
 
         create_stmt = self._generate_create_table(
             created_table, schema=(schema or obj.schema())
-        ).sql(self.name)
+        ).sql(dialect)
 
         with self.begin() as cur:
             cur.execute(create_stmt)
 
             if insert_query is not None:
                 cur.execute(
-                    sge.Insert(this=created_table, expression=insert_query).sql(
-                        self.name
-                    )
+                    sge.Insert(this=created_table, expression=insert_query).sql(dialect)
                 )
 
+                if in_memory:
+                    cur.execute(
+                        sge.Drop(kind="TABLE", this=obj.get_name(), exists=True).sql(
+                            dialect
+                        )
+                    )
+
             if overwrite:
                 cur.execute(
-                    sge.Drop(kind="TABLE", this=table, exists=True).sql(self.name)
+                    sge.Drop(kind="TABLE", this=table, exists=True).sql(dialect)
                 )
                 # SQLite's ALTER TABLE statement doesn't support using a
                 # fully-qualified table reference after RENAME TO. Since we
                 # never rename between databases, we only need the table name
                 # here.
                 quoted_name = _quote(name)
                 cur.execute(
-                    f"ALTER TABLE {created_table.sql(self.name)} RENAME TO {quoted_name}"
+                    f"ALTER TABLE {created_table.sql(dialect)} RENAME TO {quoted_name}"
                 )
 
         if schema is None:

ibis/backends/sqlite/tests/test_client.py

@@ -4,6 +4,7 @@
 import sqlite3
 from pathlib import Path
 
+import pandas as pd
 import pytest
 from pytest import param
 
@@ -101,3 +102,11 @@ def test_list_temp_tables_by_default(con):
     con.create_table(name, schema={"a": "int"}, temp=True)
     assert name in con.list_tables(database="temp")
     assert name in con.list_tables()
+
+
+@pytest.mark.parametrize("temp", [False, True])
+def test_create_table_from_in_memory_data(temp):
+    con = ibis.sqlite.connect()
+    con.create_table("foo", pd.DataFrame({"id": [1, 2, 3]}), temp=temp)
+
+    assert con.list_tables() == ["foo"]