Add call to MTCValidator #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plus.yml to match MTC guideline
landonreed
reviewed
Apr 14, 2020
| @@ -313,11 +310,9 @@ public void validate(MonitorableJob.Status status) { | |||
| // run validation on feed version | |||
| // FIXME: pass status to validate? Or somehow listen to events? | |||
| status.update("Validating feed...", 33); | |||
| validationResult = GTFS.validate(feedLoadResult.uniqueIdentifier, DataManager.GTFS_DATA_SOURCE); | |||
| validationResult = GTFS.validate(feedLoadResult.uniqueIdentifier, DataManager.GTFS_DATA_SOURCE, MTCValidator::new); | |||
There was a problem hiding this comment.
@binh-dam-ibigroup, I think we should only run the MTCValidator if the MTC extension is enabled isExtensionEnabled("mtc"). We only want the MTC-specific checks running on MTC instances of Data Tools, not for everyone. We should also add some commentary about this.
landonreed
suggested changes
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## mtc-20200310 #297 +/- ##
==================================================
- Coverage 20.74% 20.03% -0.72%
+ Complexity 468 414 -54
==================================================
Files 152 151 -1
Lines 9186 8329 -857
Branches 1320 1146 -174
==================================================
- Hits 1906 1669 -237
+ Misses 7116 6509 -607
+ Partials 164 151 -13
Continue to review full report at Codecov.
|
landonreed
approved these changes
Apr 14, 2020
|
🎉 This PR is included in version 3.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
This PR adds a call to
MTCValidatorand updates gtfsplus.yml to match MTC guidelines.MTCValidatoris available on the field-lengh-validator (MTC) branch of gtfs-lib or on the main branch if (conveyal/gtfs-lib#276 is merged (the normal CI process fails the build because of that).