Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gtfs-lib to version 5.1.0 #275

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Update gtfs-lib to version 5.1.0 #275

merged 1 commit into from
Feb 4, 2020

Conversation

evansiroky
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

This bumps gtfs-lib to 5.1.0 in order to imporve the graphql querying to provide needed data to implmenet ibi-group/datatools-ui#477. The PR ibi-group/datatools-ui#527 depends on this.

@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #275 into dev will increase coverage by 1.44%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                dev     #275      +/-   ##
============================================
+ Coverage     20.14%   21.58%   +1.44%     
- Complexity      406      427      +21     
============================================
  Files           151      151              
  Lines          8196     8366     +170     
  Branches       1101     1164      +63     
============================================
+ Hits           1651     1806     +155     
- Misses         6399     6407       +8     
- Partials        146      153       +7
Flag Coverage Δ Complexity Δ
#unit_tests 20.14% <ø> (ø) 406 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 821ea63...a42cb78. Read the comment docs.

Copy link
Contributor

@landonreed landonreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but we should consider making some quick updates to the NewGtfsErrorType priority values to be a bit more useful (some high priority issues are not a big deal, some medium priority issues will likely break OTP).

@binh-dam-ibigroup
Copy link
Contributor

Approved, but we should consider making some quick updates to the NewGtfsErrorType priority values to be a bit more useful (some high priority issues are not a big deal, some medium priority issues will likely break OTP).

Create a ticket.

@landonreed
Copy link
Contributor

Yep good call, @binh-dam-ibigroup. conveyal/gtfs-lib#272

@landonreed landonreed merged commit a772c7d into dev Feb 4, 2020
@landonreed landonreed deleted the gtfs-lib-5-1-0-bump branch February 4, 2020 21:53
@landonreed
Copy link
Contributor

🎉 This PR is included in version 3.7.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants