improvement(Added unit test): New unit test to make sure no errors are flagged

Author: br648

src/test/java/com/conveyal/datatools/manager/models/transform/RemoveNonRevenueTripsTransformationTest.java

@@ -158,6 +158,17 @@ void testDirectNonRevenueTripRemovalTransformation() throws Exception {
         assertFalse(hasNonRevenueTrips(zipTarget.gtfsFile.getAbsolutePath()));
     }
 
+    @Test
+    void testDirectNonRevenueTripRemovalTransformationFail() throws Exception {
+        // Feed is missing required pickup and drop off fields. This will stop the transformation, but should not flag
+        // it has failed. Subsequent transformations and import can then still take place.
+        File zip = zipFolderFiles("non-revenue-trips-fail");
+        FeedTransformZipTarget zipTarget = new FeedTransformZipTarget(zip);
+        MonitorableJob.Status status = new MonitorableJob.Status();
+        trans.transform(zipTarget, status);
+        assertFalse(status.error);
+    }
+
     private void hadExpectTransformResults(List<TableTransformResult> tableTransformResults) {
         assertEquals(2, tableTransformResults.size());
         assertEquals(5, tableTransformResults.get(0).deletedCount);

src/test/resources/com/conveyal/datatools/gtfs/non-revenue-trips-fail/stop_times.txt

@@ -0,0 +1,10 @@
+trip_id,arrival_time,departure_time,stop_id,continuous_pickup,continuous_drop_off
+non-revenue-trip,04:58:00,04:58:00,CONC,1,1
+non-revenue-trip,05:03:00,05:03:00,PHIL,1,1
+non-revenue-trip,05:06:00,05:06:00,WCRK,1,1
+non-revenue-trip,05:11:00,05:11:00,LAFY,1,1
+non-revenue-trip,05:12:00,05:13:00,TGLD,1,1
+revenue-trip,04:58:00,04:58:00,CONC,0,0
+revenue-trip,05:03:00,05:03:00,PHIL,1,1
+revenue-trip,05:06:00,05:06:00,WCRK,1,1
+revenue-trip,05:11:00,05:11:00,LAFY,0,0