Added rector rule to replace ContentType::isContainer property to method (#25)

Author: wiewiurdp

src/contracts/Sets/ibexa-50.php

@@ -210,4 +210,22 @@
             'replace_with' => 'Ibexa\Contracts\Core\Variation\VariationPathGenerator',
         ]
     );
+
+    $rectorConfig->ruleWithConfiguration(PropertyToGetterRector::class, [
+        'Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType' => [
+            'isContainer' => 'isContainer',
+        ],
+    ]);
+
+    $rectorConfig->ruleWithConfiguration(PropertyToGetterRector::class, [
+        'Ibexa\Contracts\Core\Repository\Values\ContentType\ContentTypeDraft' => [
+            'isContainer' => 'isContainer',
+        ],
+    ]);
+
+    $rectorConfig->ruleWithConfiguration(PropertyToGetterRector::class, [
+        'Ibexa\Core\Repository\Values\ContentType\ContentTypeDraft' => [
+            'isContainer' => 'isContainer',
+        ],
+    ]);
 };

tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_content_type_draft_is_container.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Core\Repository\Values\ContentType\ContentTypeDraft;
+
+readonly class Foo
+{
+    public function foo(ContentTypeDraft $contentTypeDraft): array
+    {
+        return [$contentTypeDraft->isContainer];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Core\Repository\Values\ContentType\ContentTypeDraft;
+
+readonly class Foo
+{
+    public function foo(ContentTypeDraft $contentTypeDraft): array
+    {
+        return [$contentTypeDraft->isContainer()];
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_content_type_is_container.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType;
+
+readonly class Foo
+{
+    public function foo(ContentType $contentType): array
+    {
+        return [$contentType->isContainer];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentType;
+
+readonly class Foo
+{
+    public function foo(ContentType $contentType): array
+    {
+        return [$contentType->isContainer()];
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/change_property_to_method_contracts_content_type_draft_is_container.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentTypeDraft;
+
+readonly class Foo
+{
+    public function foo(ContentTypeDraft $contentTypeDraft): array
+    {
+        return [$contentTypeDraft->isContainer];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\ContentType\ContentTypeDraft;
+
+readonly class Foo
+{
+    public function foo(ContentTypeDraft $contentTypeDraft): array
+    {
+        return [$contentTypeDraft->isContainer()];
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_class_update_serializer.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Solr\Gateway\UpdateSerializer;
+
+readonly class Foo
+{
+    public function __construct(UpdateSerializer $updateSerializer)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Solr\Gateway\UpdateSerializer\XmlUpdateSerializer;
+
+readonly class Foo
+{
+    public function __construct(XmlUpdateSerializer $updateSerializer)
+    {
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_const_content_type_identifier.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Migration\ValueObject\ContentType\Matcher;
+
+readonly class Foo
+{
+    public function fooBar(): string
+    {
+        return Matcher::CONTENT_TYPE_IDENTIFIER;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Migration\StepExecutor\ContentType\IdentifierFinder;
+use Ibexa\Migration\ValueObject\ContentType\Matcher;
+
+readonly class Foo
+{
+    public function fooBar(): string
+    {
+        return IdentifierFinder::CONTENT_TYPE_IDENTIFIER;
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_const_tree_root.php.inc

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Bundle\FormBuilder\DependencyInjection\Configuration;
+
+readonly class Foo
+{
+    public function fooBar(): string
+    {
+        return Configuration::TREE_ROOT;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Bundle\FormBuilder\DependencyInjection\IbexaFormBuilderExtension;
+use Ibexa\Bundle\FormBuilder\DependencyInjection\Configuration;
+
+readonly class Foo
+{
+    public function fooBar(): string
+    {
+        return IbexaFormBuilderExtension::EXTENSION_NAME;
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_field_namespace_content_to_common.php.inc

@@ -0,0 +1,29 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Solr\Query\Content\CriterionVisitor\Field;
+
+readonly class Foo
+{
+    public function __construct(Field $field)
+    {
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Solr\Query\Common\CriterionVisitor\Field;
+
+readonly class Foo
+{
+    public function __construct(Field $field)
+    {
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_property_searchresult_count.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\Content\Trash\SearchResult;
+
+readonly class Foo
+{
+    public function foo(SearchResult $searchResult): string
+    {
+        return $searchResult->count;
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\Content\Trash\SearchResult;
+
+readonly class Foo
+{
+    public function foo(SearchResult $searchResult): string
+    {
+        return $searchResult->totalCount;
+    }
+}
+
+?>

tests/lib/Sets/Ibexa50/Fixture/rename_property_searchresult_spell_suggestion.php.inc

@@ -0,0 +1,31 @@
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchResult;
+
+readonly class Foo
+{
+    public function foo(SearchResult $searchResult): array
+    {
+        return [$searchResult->spellSuggestion];
+    }
+}
+
+?>
+-----
+<?php
+
+namespace Rector\Tests\TypeDeclaration\Rector\ReplaceCartMoneyFactoryRector\Fixture;
+
+use Ibexa\Contracts\Core\Repository\Values\Content\Search\SearchResult;
+
+readonly class Foo
+{
+    public function foo(SearchResult $searchResult): array
+    {
+        return [$searchResult->spellcheck];
+    }
+}
+
+?>