Apply suggestions from code review

adamwojs · Steveb-p · adamwojs · commit 91cbd039a82b · 2024-08-01T08:50:29.000+02:00
Co-authored-by: Paweł Niedzielski &lt;pawel.niedzielski@ibexa.co&gt;
diff --git a/src/bundle/Resources/views/themes/admin/ui/field_type/edit/ezimage.html.twig b/src/bundle/Resources/views/themes/admin/ui/field_type/edit/ezimage.html.twig
@@ -55,8 +55,8 @@
                         'image-edit-actions-after',
                         {
                             'fieldDefinitionIdentifier' : form.parent.vars.value.fieldDefinition.identifier,
-                            'contentId' : content_id|default(app.request.get('contentId')),
-                            'versionNo' : version_no|default(app.request.get('versionNo')),
+                            'contentId' : content_id ?? app.request.get('contentId'),
+                            'versionNo' : version_no ?? app.request.get('versionNo'),
                             'disabled': readonly ? true : false,
                         }
                     ) }}
diff --git a/src/bundle/Resources/views/themes/admin/ui/field_type/edit/ezimageasset.html.twig b/src/bundle/Resources/views/themes/admin/ui/field_type/edit/ezimageasset.html.twig
@@ -145,8 +145,8 @@
                         'image-edit-actions-after',
                         {
                             'fieldDefinitionIdentifier' : form.parent.vars.value.fieldDefinition.identifier,
-                            'contentId' : content_id|default(app.request.get('contentId')),
-                            'versionNo' : version_no|default(app.request.get('versionNo')),
+                            'contentId' : content_id ?? app.request.get('contentId'),
+                            'versionNo' : version_no ?? app.request.get('versionNo'),
                             'disabled': readonly ? true : false,
                         }
                     ) }}

Original file line number	Diff line number	Diff line change
`@@ -55,8 +55,8 @@`
`55`	`55`	`'image-edit-actions-after',`
`56`	`56`	`{`
`57`	`57`	`'fieldDefinitionIdentifier' : form.parent.vars.value.fieldDefinition.identifier,`
`58`		`- 'contentId' : content_id\|default(app.request.get('contentId')),`
`59`		`- 'versionNo' : version_no\|default(app.request.get('versionNo')),`
	`58`	`+ 'contentId' : content_id ?? app.request.get('contentId'),`
	`59`	`+ 'versionNo' : version_no ?? app.request.get('versionNo'),`
`60`	`60`	`'disabled': readonly ? true : false,`
`61`	`61`	`}`
`62`	`62`	`) }}`
Original file line number	Diff line number	Diff line change
`@@ -145,8 +145,8 @@`
`145`	`145`	`'image-edit-actions-after',`
`146`	`146`	`{`
`147`	`147`	`'fieldDefinitionIdentifier' : form.parent.vars.value.fieldDefinition.identifier,`
`148`		`- 'contentId' : content_id\|default(app.request.get('contentId')),`
`149`		`- 'versionNo' : version_no\|default(app.request.get('versionNo')),`
	`148`	`+ 'contentId' : content_id ?? app.request.get('contentId'),`
	`149`	`+ 'versionNo' : version_no ?? app.request.get('versionNo'),`
`150`	`150`	`'disabled': readonly ? true : false,`
`151`	`151`	`}`
`152`	`152`	`) }}`