Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Region should get enum #18

Open
guyluz11 opened this issue Apr 5, 2023 · 1 comment
Open

Region should get enum #18

guyluz11 opened this issue Apr 5, 2023 · 1 comment

Comments

@guyluz11
Copy link
Contributor

guyluz11 commented Apr 5, 2023

The region field is mandatory when login in to the account, I would prefer if there were a way to login to the account without inserting the region.
But if not let's change the region field to get an enum of all the supported countries, with that we can keep another factory method for inserting it by text.

Another thing about the region that it will solve is how I should use it.
In the official eWeLink app I am inserting region by selecting the country name plus 3 pre phone numbers.
So I am not sure in what way to insert the region, is it a full country name, 3 letters, 2 letters, pre-phone number numbers?.
Adding an enum will also solve this issue for future developers.

@guyluz11
Copy link
Contributor Author

guyluz11 commented Apr 5, 2023

Found out in the docs that we can get the region for the user without specifying it manually

https://ewelink-api.vercel.app/docs/available-methods/getregion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant