Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved http-client support #8

Open
iand675 opened this issue Nov 29, 2021 · 2 comments
Open

improved http-client support #8

iand675 opened this issue Nov 29, 2021 · 2 comments

Comments

@iand675
Copy link
Owner

iand675 commented Nov 29, 2021

(net.* attributes, especially)
@lf-
Copy link
Collaborator

lf- commented Sep 29, 2022

Also it seems that the docs are inaccurate about being able to instrument via the manager, or at least they're unclear.

@lf-
Copy link
Collaborator

lf- commented Oct 3, 2022

Idea on how to implement the manager instrumentation: use managerWrapException, since it seems that it gets wrapped around every request. But unfortunately this doesn't actually follow the lifecycle of the request properly: it would only be seeing the part where the headers are sent, but if someone were to stream the request, it would end early.

https://github.com/snoyberg/http-client/blob/dc6b2c29f1744618dc8b15afc8c3a960815acdbc/http-client/Network/HTTP/Client/Core.hs#L206-L211

This was referenced Oct 3, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iand675 @lf-