Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runner should error out on invalid commands #181

Open
KerakTelor86 opened this issue Jun 25, 2021 · 0 comments
Open

Runner should error out on invalid commands #181

KerakTelor86 opened this issue Jun 25, 2021 · 0 comments

Comments

@KerakTelor86
Copy link

KerakTelor86 commented Jun 25, 2021

This is really minor and probably not all that important so feel free to not waste your time on this.

So currently, the runner executable generated by tcframe runs in generation mode whenever an invalid command is issued e.g. ./runner grader. I think it probably should behave similarly to tcframe itself in these cases and list the available commands without running anything.

So I've had a few run-ins with this issue and my experience kind of looked like this:

  • The output for generation and grading looks quite similar (in that there are test groups, test file names, and some form of good / bad feedback)
  • The --solution argument (which our team usually uses for grading) works for generation too.
  • Type in ./runner gr_s_de --solution=./clearly-wa-solution (underscores for emphasis)
  • A bunch of OKs show up instead of the expected Wrong Answer.
  • Re-run the command by tapping up arrow and pressing the return key. More OKs show up.
  • Get really confused. Check clearly-wa-solution.cpp for mistakes. Check intended-solution.cpp for mistakes.
  • Repeat for 15 minutes until either I realize I've made a typo or I realize it says Generation finished instead of Accepted at the bottom.

I realize this whole issue is really just my own fault, but I think it might save people a few minutes if it kind of errored out, y'know? I guess changing the message to Generation successful instead of OK would probably also work in this instance, although I'm not really sure which method would work better.

Thank you for reading, have a good day!

@KerakTelor86 KerakTelor86 changed the title [Suggestion] Runner should error out on invalid commands Runner should error out on invalid commands Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant