driver compatable with truenas 12? #23
Comments
|
Are you using the master version of this repo? |
|
Hy,
The one downloaded and installed with
git clone --depth=1 https://github.com/iXsystems/cinder
cp -R ./cinder/driver/ixsystems/ /usr/lib/python3/dist-packages/cinder/volume/drivers/
Greetings,
Marc
Are you using the master version of this repo?
|
|
Doesn't ring a bell, I have not been using it myself. Looks like the API reply was empty or invalid. Would need happen from somebody to debug it |
|
Looks like the error is happening when attempting to get volume stats. William, if you'll recall when I updated this driver to use the new v2 API we had an issue where the volume stats were only available using the older 1.0 API, so that one portion of this driver still relies on the older API. Is it possible that with truenas 12 support for the older API has been taken out and so that call is failing? I haven't installed 12 yet myself for testing ... |
|
Ah yes. 12.0 removes support for v1.0 API |
|
thanks for the confirmation. will there be a new version which adresses this issue? |
|
I am guessing that will have to wait until I have time to tackle it in the new year. I should have time in January to install a new test environment with 12 and update the code. If anyone else wants to tackle this in the meantime I have some documentation I generated for the 1.0 -> 2.0 upgrade I can share that will help. |
|
@dmcgrandle is would be swell if you could share the 1.0 -> 2.0 upgrade notes. |
|
this commit shosti@b4aabdf by @shosti appears to enable the 2.0 API for volume stats, and as well has another commit in their repo to handle API keys instead of using root username/password. |
|
Oh yeah I think I got it working with API v2 on https://github.com/shosti/cinder/tree/api-key . Never got it up and running to the extent that I could verify that it works end-to-end which is why I didn’t open a PR, but I’m happy opening a PR if someone wants to test it. |
|
I'm in the process of testing out your branch right now, I'll let you know how the integration goes -- at least as an additional data point for whether or not it works as expected. |
|
@shosti at the most basic level, it's working 100% so far. stats work, volume create/delete works. I'll be running it through it's paces a little more over the next few days. |
|
Good work, and this is very interesting. A couple of comments:
With these points in mind, the updated code for |
|
I think it’s best if someone forks my code and opens up a new PR—I’m not really comfortable opening up a PR that I have no way of testing. |
|
if needed i can build a test setup later to test things out. |
|
We've been using this since January and have only come across one issue where if something gets wonky, volumes can't be deleted through cinder if they're in error state but never made it to the backend. Feel free to include it if this ever goes forward in a new PR. def _delete_volume(self, name):
"""Deletes specified volume
"""
request_urn = ('%s/id/%s%s') % (FreeNASServer.REST_API_VOLUME,
urllib.parse.quote_plus(self.configuration.ixsystems_dataset_path + '/'), name)
LOG.debug('_delete_volume urn : %s', request_urn)
+
+ check_ret = self.handle.invoke_command(
+ FreeNASServer.SELECT_COMMAND,
+ request_urn, None)
+
+ if check_ret['status'] == FreeNASServer.STATUS_ERROR \
+ and '404:Not Found' in check_ret['response']:
+ return None
+
clone = self._dependent_clone(name) # add check for dependent clone, if exists will delete
ret = self.handle.invoke_command(FreeNASServer.DELETE_COMMAND,
``` |
|
Hello, has there been any movement on this issue? I am using TrueNAS Core 12 with Kolla-ansible Openstack, Ussuri build. I tried using https://github.com/shosti/cinder/tree/api-key fork but get the error below in my cinder-volumes.log file. Any insight or direction would be appriciated=) 2021-04-21 13:27:43.361 210 INFO cinder.volume.manager [req-90ccc720-3611-4263-855b-d3574087b76a - - - - -] Starting volume driver FreeNASISCSIDriver (2.0.0) |
|
Hello, I am playing around with trueNas at home in a vm. I am running into this same problem. It seems that the driver is broken at this point. I am an OpenStack cinder core dev and I am running into the same issue. This is one of the reasons why we encourage projects to try and get their drivers into the cinder tree, which requires a working CI system to ensure the driver actually works for each cinder release. We have an extensive testing setup to ensure that drivers pass the rigorous testing to ensure that drivers work properly when they are deployed. I would encourage you to join our irc channel and see if it's possible to add the driver to the tree. We are on irc.freenode.net. Channel #openstack-cinder |
|
The response I'm getting back inside of _update_volume_stats() is straight html for the call to fetch the stats from the API. |
|
@hemna with the patches applied from earlier in the thread the driver has worked for me with very minimal modification in queens, victoria and wallaby. sounds like it may be a config issue if you're up to date with the latest replies and getting wonky API responses. |
|
I replaced the common._update_volume_stats() from #23 (comment) and that seems to have worked. I'm noticing inconsistencies with the driver and the cinder manager API expectations, that I've been able to overcome a bit with changes to the cinder.conf driver settings. I'll file a separate issue for that. But I can't create a volume now. I have trunas 12.0 in a vm and have create a pool with a dataset in it. Looking at the c-vol log, it looks like the driver is trying to create an iscsi target during create_volume() time, which is really odd. That shouldn't be happening until initialize_connection() is called. This is incorrect cinder driver behavior. It looks like the call to common._create_volume() works, and then fails during the incorrect call to common._create_iscsitarget(). This leaves the volume in an error state and unusuable. |
|
This should has been fixed on master branch now. New implementation for function _update_volume_stats uses v2.0 API has been merged to https://github.com/iXsystems/cinder/blob/master/driver/ixsystems/common.py#L431 Tested on my environments: TrueNAS-12.0-U8.1 (working) |
Hy,
i have installed a ussuri openstack with a truenas 12 storage system. The problem i face is that i can't connect with this cinder driver to my storage unit. As a workaround i downgrade to 11.3 update 5 freenas and now it works like a charm. i havent made any changes to my openstack configs for it to work.
this is an output of my cinder volume log.
2020-11-25 12:26:29.193 37975 INFO cinder.volume.manager [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] Starting volume driver FreeNASISCSIDriver (2.0.0)
2020-11-25 12:26:29.193 37975 INFO cinder.volume.drivers.ixsystems.iscsi [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] iXsystems Do Setup
2020-11-25 12:26:29.194 37975 INFO cinder.volume.drivers.ixsystems.iscsi [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] iXSystems: Check For Setup Error
2020-11-25 12:26:29.194 37975 INFO cinder.volume.drivers.ixsystems.iscsi [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] iXSystems: Check For Setup Error
2020-11-25 12:26:29.195 37975 INFO cinder.volume.drivers.ixsystems.iscsi [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] iXsystems Get Volume Status
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service [req-d55ea4c0-4095-47ad-944a-e8cc4b1cebc8 - - - - -] Error starting thread.: simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service Traceback (most recent call last):
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/oslo_service/service.py", line 810, in run_service
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service service.start()
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/service.py", line 228, in start
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service self.manager.init_host(added_to_cluster=self.added_to_cluster,
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/volume/manager.py", line 443, in init_host
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service self._init_host(added_to_cluster, **kwargs)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/volume/manager.py", line 477, in _init_host
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service self.driver.init_capabilities()
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/volume/driver.py", line 770, in init_capabilities
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service stats = self.get_volume_stats(True)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/volume/drivers/ixsystems/iscsi.py", line 199, in get_volume_stats
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service self.stats = self.common._update_volume_stats()
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/cinder/volume/drivers/ixsystems/common.py", line 368, in _update_volume_stats
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service data['total_capacity_gb'] = ix_utils.get_size_in_gb(json.loads(ret['response'])['avail'] + json.loads(ret['response'])['used'])
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/simplejson/init.py", line 518, in loads
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service return _default_decoder.decode(s)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 370, in decode
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service obj, end = self.raw_decode(s)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service File "/usr/lib/python3/dist-packages/simplejson/decoder.py", line 400, in raw_decode
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service return self.scan_once(s, idx=_w(s, idx).end())
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service simplejson.errors.JSONDecodeError: Expecting value: line 1 column 1 (char 0)
2020-11-25 12:26:29.199 37975 ERROR oslo_service.service
2020-11-25 12:26:29.209 37890 INFO oslo_service.service [req-40937f36-8916-4ef8-a741-45301f10732f - - - - -] Child 37975 exited with status 1
2020-11-25 12:26:29.218 37976 INFO cinder.service [-] Starting cinder-volume node (version 16.2.0)
has someone else tried it and got the same error? i have fully installed my openstack from scratch back then and i got the same error 2 times.
my cinder conf is
[ixsystems-iscsi]
iscsi_helper = tgtadm
volume_dd_blocksize = 512
volume_driver = cinder.volume.drivers.ixsystems.iscsi.FreeNASISCSIDriver
ixsystems_login = someloginname
ixsystems_password = somepassword
ixsystems_server_hostname = someipadress
ixsystems_volume_backend_name = iXsystems_FREENAS_Storage
ixsystems_iqn_prefix = iqn.2005-10.org.freenas.ctl
ixsystems_datastore_pool = Tank1
ixsystems_dataset_path = Tank1/XS-SH-ISCSI
ixsystems_vendor_name = iXsystems
ixsystems_storage_protocol = iscsi
#volume_backend_name = ixsystems-iscsi
The text was updated successfully, but these errors were encountered: