Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core logs should indicate the version used to generate them #191

Open
psybers opened this issue Jul 26, 2023 · 1 comment
Open

Core logs should indicate the version used to generate them #191

psybers opened this issue Jul 26, 2023 · 1 comment
Labels
Enhancement Good First Issue Good issue for someone new to the project

Comments

@psybers
Copy link

psybers commented Jul 26, 2023

The <itrace_core> tag currently includes attributes like the session id etc. It should also indicate which version of iTrace core was being run, which could aid replicability. I recommend adding a version attribute.

@psybers psybers added Enhancement Good First Issue Good issue for someone new to the project labels Jul 26, 2023
@psybers
Copy link
Author

psybers commented Jul 26, 2023

You can get the assembly's version with something like this:

using System;
using System.Reflection;

private string GetVersionString()
{
    return Assembly.GetEntryAssembly().GetName().Version.ToString();
}

and then in itrace_core/XMLGazeDataWriter.cs add this to the WriteSessionInformation() method (line 47):

xmlTextWriter.WriteAttributeString("version", GetVersionString());

Could possibly cache the version info into the session manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Good First Issue Good issue for someone new to the project
Projects
None yet
Development

No branches or pull requests

1 participant