Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in manifest.json breaking extension #17

Open
Robertdebrus opened this issue Jul 19, 2022 · 4 comments
Open

Typo in manifest.json breaking extension #17

Robertdebrus opened this issue Jul 19, 2022 · 4 comments
Assignees
@KangilPark

Comments

@Robertdebrus
Copy link

Line 47 of manifest.json reads: "scripts": ["/assets/js/jQuery-3.3.1.js", "/assets/js/background.js"], but the jQuery file located at /assets/js is named jquery-3.3.1.js, which breaks the plugin, unable to be installed without modifying it
@shbonita
Copy link
Contributor

@KangilPark can you please take a look at this issue?

@KangilPark
Copy link
Contributor

Should be fixed now. Can you verify this @Robertdebrus ?

@Robertdebrus
Copy link
Author

I just checked it, it works! Thanks, @KangilPark!

@shbonita
Copy link
Contributor

@Robertdebrus quick question. What was your machine setup? OS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KangilPark KangilPark

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shbonita @KangilPark @Robertdebrus