Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TileBuilder refacto #2470

Open
jailln opened this issue Nov 27, 2024 · 0 comments
Open

TileBuilder refacto #2470

jailln opened this issue Nov 27, 2024 · 0 comments

Comments

@jailln
Copy link
Contributor

jailln commented Nov 27, 2024

Tile builder design pattern is not really clear... There are some circular dependencies and I think that separation of concerns is not really effective. I think we should aim at: (and we are not far from it)

  • interface TileBuilder
  • implemented by PlanarTileBuilder and GlobeTileBuilder
  • each having a method returning a new TileGeometry based on relevant TileBuilderParams (the current newTileGeometry)
  • TileGeometry being only a data model that does not know about the TileBuilder.

Originally posted by @jailln in #2440 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jailln