Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete prepare script #2462

Open
gchoqueux opened this issue Nov 12, 2024 · 1 comment
Open

Obsolete prepare script #2462

gchoqueux opened this issue Nov 12, 2024 · 1 comment

Comments

@gchoqueux
Copy link
Contributor

gchoqueux commented Nov 12, 2024

  • This script prepare.mjs is clearly outdated (some dev dependencies now require node > 18.0) and we could simply specify the requirement for both node and npm directly in the package.json with
  "engines" : { 
    "node" : ">=18.0.0"
  }
  • Since we now have an ESM distribution, I think we could remove the ThreeExtended script and directly imports from three/addons/*.

Originally posted by @Desplandis in #2300 (comment)

@gchoqueux gchoqueux mentioned this issue Nov 12, 2024
15 tasks
@Desplandis
Copy link
Contributor

Okay, I'll push a fix after your PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants