Skip to content
This repository has been archived by the owner on Mar 17, 2022. It is now read-only.

Notices when WooCommerce pages missing #462

Closed
benrich opened this issue Sep 16, 2019 · 2 comments
Closed

Notices when WooCommerce pages missing #462

benrich opened this issue Sep 16, 2019 · 2 comments

Comments

@benrich
Copy link

benrich commented Sep 16, 2019

Great plugin. I have a use case though I don't think has been considered before and the "create missing WC pages" feature of this plugin is super annoying. Perhaps there's scope to change a few bits..

My shop doesn't need a basket, checkout or my-account page. I'm using WC as a catalog, which I think is quite typical. I would expect the Settings > WooPoly > "Check WooCommerce Pages" option, if unticked, to disable all those checks.

Can you reproduce this issue on default Wordpress theme (eg Storefront)?

Yes

Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?

Yes

What product versions and settings are you using when this issue occurs?

  • PHP: 7.2
  • WordPress: 5.2.3
  • WooCommerce: 3.7.0
  • Polylang: [state if using Polylang PRO] Free version
  • Hyyan WooCommerce Polylang Integration: 1.4.3
  • Browser: Chrome

Steps to Reproduce

  1. Install WC
  2. delete all WC pages
  3. install WooPoly
  4. go into WooPoly settings and untick "Check WooCommerce Pages"
  5. delete all WC pages (because you don't need them) except the shop page
  6. refresh any admin page and WooPoly warns that the shop won't work without WC pages

What I Expected

In the last step above I would expect WooPoly not to warn me because I have unselected the "Check WooCommerce Pages" option.

What Happened Instead

On every admin page, WooPoly warns that loads of WC pages are missing. It's frustrating because the functionality is exactly as I want it. It's perfect. Except I have these warnings all over the place. Warnings that are in fact false for a catalog use case.

So what I feel is needed is to remove all those WC page checks if that option is unselected. (actually do what that setting claims).

Thanks in advance!

WordPress Environment

``` ` ### WordPress Environment ###

WordPress address (URL): https://adela.benrich.uk
Site address (URL): https://adela.benrich.uk
WC Version: 3.7.0
REST API Version: ✔ 1.0.2
Log Directory Writable: ✔
WP Version: 5.2.3
WP Multisite: ✔
WP Memory Limit: 256 MB
WP Debug Mode: –
WP Cron: ✔
Language: en_GB
External object cache: –

Server Environment

Server Info: Apache
PHP Version: 7.3.9
PHP Post Max Size: 12 MB
PHP Time Limit: 30
PHP Max Input Vars: 1000
cURL Version: 7.65.3
OpenSSL/1.0.2s

SUHOSIN Installed: –
MySQL Version: 5.6.44-log
Max Upload Size: 10 MB
Default Timezone is UTC: ✔
fsockopen/cURL: ✔
SoapClient: ✔
DOMDocument: ✔
GZip: ✔
Multibyte String: ✔
Remote Post: ✔
Remote Get: ✔

Database

WC Database Version: 3.7.0
WC Database Prefix: brwp_34_
MaxMind GeoIP Database: ✔
Total Database Size: 2.72MB
Database Data Size: 2.34MB
Database Index Size: 0.38MB
brwp_34_woocommerce_sessions: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_api_keys: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_attribute_taxonomies: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_downloadable_product_permissions: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_order_items: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_order_itemmeta: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_tax_rates: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_tax_rate_locations: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_shipping_zones: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_shipping_zone_locations: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_shipping_zone_methods: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_payment_tokens: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_payment_tokenmeta: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_woocommerce_log: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_commentmeta: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_comments: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_layerslider: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_layerslider_revisions: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_links: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_options: Data: 1.00MB + Index: 0.04MB + Engine MyISAM
brwp_34_postmeta: Data: 0.32MB + Index: 0.13MB + Engine MyISAM
brwp_34_posts: Data: 0.24MB + Index: 0.04MB + Engine MyISAM
brwp_34_termmeta: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_terms: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_term_relationships: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_term_taxonomy: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_wc_download_log: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_34_wc_product_meta_lookup: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_wc_tax_rate_classes: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_34_wc_webhooks: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_blogmeta: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_blogs: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_blog_versions: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_registration_log: Data: 0.00MB + Index: 0.00MB + Engine MyISAM
brwp_signups: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_site: Data: 0.00MB + Index: 0.01MB + Engine MyISAM
brwp_sitemeta: Data: 0.50MB + Index: 0.03MB + Engine MyISAM
brwp_usermeta: Data: 0.28MB + Index: 0.04MB + Engine MyISAM
brwp_users: Data: 0.00MB + Index: 0.01MB + Engine MyISAM

Security

Secure connection (HTTPS): ✔
Hide errors from visitors: ✔

Active Plugins (5)

Polylang: by WP SYNTEX – 2.6.4
Hyyan WooCommerce Polylang Integration: by Hyyan Abo Fakher – 1.4.3 – Not tested with the active version of WooCommerce
WooCommerce: by Automattic – 3.7.0
Network Plugin Auditor: by Katherine Semel – 1.10.1
Classic Editor: by WordPress Contributors – 1.5

Inactive Plugins (17)

Admin Columns: by AdminColumns.com – 3.4.6
AJAX Thumbnail Rebuild: by junkcoder
ristoniinemets – 1.13

Akismet Anti-Spam: by Automattic – 4.1.2
Autoptimize: by Frank Goossens (futtta) – 2.5.1
Ben WP Plugin: by Ben Rich – 1.0
Contact Form 7: by Takayuki Miyoshi – 5.1.4
Import External Images: by Marty Thornley – 1.4
Mailgun: by Mailgun – 1.7.1
MultiSite Clone Duplicator: by Julien OGER
Pierre DARGHAM
David DAUGREILH
GLOBALIS media systems – 1.5.3

Nav Menu Roles: by Kathy Darling – 1.9.3
Nested Pages: by Kyle Phillips – 3.1.3
reSmush.it Image Optimizer: by reSmush.it – 0.1.22
Smart Logo Showcase Lite: by AccessPress Themes – 1.1.2
Theme My Login: by Jeff Farthing – 999996.4.16
WordPress Importer: by wordpressdotorg – 0.6.4
WP Super Cache: by Automattic – 1.7.0
Yoast SEO: by Team Yoast – 12.0

Dropin Plugins (1)

sunrise.php: sunrise.php

Must Use Plugins (1)

WordPress MU Domain Mapping: by Donncha O Caoimh – 0.5.4.3

Settings

API Enabled: –
Force SSL: –
Currency: CZK (Kč)
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Number of Decimals: 2
Taxonomies: Product Types: downloadable (downloadable)
external (external)
grouped (grouped)
simple (simple)
variable (variable)
virtual (virtual)

Taxonomies: Product Visibility: exclude-from-catalog (exclude-from-catalog)
exclude-from-search (exclude-from-search)
featured (featured)
outofstock (outofstock)
rated-1 (rated-1)
rated-2 (rated-2)
rated-3 (rated-3)
rated-4 (rated-4)
rated-5 (rated-5)

Connected to WooCommerce.com: –

WC Pages

Shop base: ❌ Page not set
Basket: ❌ Page not set
Checkout: ❌ Page not set
My account: ❌ Page not set
Terms and conditions: ❌ Page not set

Theme

Name: Enfold - Adela
Version: 0.1
Author URL:
Child Theme: ✔
Parent Theme Name: Enfold
Parent Theme Version: 4.5.7
Parent Theme Author URL: https://kriesi.at
WooCommerce Support: ✔

Templates

Overrides: –

Action Scheduler

Complete: 1
Oldest: 2019-09-15 16:22:45 +0100
Newest: 2019-09-15 16:22:45 +0100

Pending: 0
Oldest: –
Newest: –

Canceled: 0
Oldest: –
Newest: –

In-progress: 0
Oldest: –
Newest: –

Failed: 0
Oldest: –
Newest: –

`

</details>
@Jon007
Copy link
Contributor

Jon007 commented Sep 21, 2019

@benrich fair enough, we should move it to the woocommerce status report on #449

@Jon007
Copy link
Contributor

Jon007 commented Jun 30, 2020

Hi, in the checked in version of Features.php and Plugin.php (possibly not in the release version you are using), the check of WooCommerce pages is an optional feature which is off by default: Settings, WooPoly, Check WooCommerce Pages.
It's still an interesting idea to add this to enhancements for Status Check but as it stands the checked in version seems ok.

@Jon007 Jon007 closed this as completed Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants