From d7607cb45d007c7890e5a73c2d1b9d81adf64376 Mon Sep 17 00:00:00 2001 From: saxenakshitiz Date: Wed, 12 Jun 2024 00:00:07 +0530 Subject: [PATCH] address review comments --- .../label/dao/LabelApplicationRuleResponseConverter.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java b/hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java index b0de69e..75cad52 100644 --- a/hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java +++ b/hypertrace-graphql-labels-schema-impl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java @@ -119,8 +119,7 @@ private Optional convertAction( null, Action.ActionType.DYNAMIC_LABEL_KEY)); case DYNAMIC_LABEL_EXPRESSION: - DynamicLabel dynamicLabel = - convertDynamicLabelExpression(action.getDynamicLabelExpression()); + DynamicLabel dynamicLabel = convertDynamicLabel(action.getDynamicLabelExpression()); return operation.map( op -> new ConvertedAction( @@ -138,7 +137,7 @@ private StaticLabels convertStaticLabels( return new ConvertedStaticLabels(staticLabels.getIdsList()); } - private DynamicLabel convertDynamicLabelExpression( + private DynamicLabel convertDynamicLabel( org.hypertrace.label.application.rule.config.service.v1.LabelApplicationRuleData.Action .DynamicLabel dynamicLabel) {