From 05beb610fd04c8093a5318a9bf335924bc69ce06 Mon Sep 17 00:00:00 2001 From: Shivansh Anand Srivastava Date: Wed, 19 Jun 2024 17:17:33 +0530 Subject: [PATCH] Resolve PR reviews --- .../spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java | 2 +- .../schema/mutation/SpanProcessingMutationSchema.java | 3 +-- .../graphql/spanprocessing/schema/rule/ExcludeSpanRule.java | 2 +- .../spanprocessing/schema/rule/ExcludeSpanRuleInfo.java | 2 +- .../schema/rule/filter/SpanProcessingRelationalFilter.java | 2 +- 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java index 1e19227..73077a7 100644 --- a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java +++ b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/ExcludeSpanRuleUpdate.java @@ -24,7 +24,7 @@ public interface ExcludeSpanRuleUpdate extends Identifiable { @GraphQLField @GraphQLName(SPAN_PROCESSING_FILTER_KEY) - @GraphQLDescription("Update the existing spanFilters for the input ruleId") + @GraphQLDescription("Replace the existing spanFilters for the input ruleId") @GraphQLNonNull SpanProcessingRuleFilter spanFilter(); diff --git a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java index 9b445e2..c9b54af 100644 --- a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java +++ b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/mutation/SpanProcessingMutationSchema.java @@ -17,8 +17,7 @@ public interface SpanProcessingMutationSchema { @GraphQLField @GraphQLName(CREATE_EXCLUDE_SPAN_RULE_MUTATION_NAME) - @GraphQLDescription( - "Create exclude span rule by providing the rule name, filters, rule type, enabled or disabled state") + @GraphQLDescription("Creates a new ExcludeSpanRule. See ExcludeSpanRule for more information.") @GraphQLNonNull @GraphQLDataFetcher(ExcludeSpanCreateRuleMutator.class) ExcludeSpanRule createExcludeSpanRule( diff --git a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java index 89abef9..4450beb 100644 --- a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java +++ b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRule.java @@ -9,7 +9,7 @@ @GraphQLName(ExcludeSpanRule.TYPE_NAME) @GraphQLDescription( - "Exclude span rules are the set of rules created using filters on span attributes based on which we exclude spans at source from reaching the platform") + "An ExcludeSpanRule describes a set of conditions based on span attributes. When matched, a span is discarded and not eligible for further processing.") public interface ExcludeSpanRule extends Identifiable, ExcludeSpanRuleInfo { String TYPE_NAME = "ExcludeSpanRule"; diff --git a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java index fd1f95c..e8a6c43 100644 --- a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java +++ b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/ExcludeSpanRuleInfo.java @@ -30,7 +30,7 @@ public interface ExcludeSpanRuleInfo { @GraphQLField @GraphQLName(DISABLED_KEY) @GraphQLDescription( - "Disabled field denotes whether the rule is disabled or not. By default it is enabled") + "Disabled field denotes whether the rule is disabled or not. By default it is enabled on write") @GraphQLNonNull boolean disabled(); diff --git a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java index 5cfd35a..9158935 100644 --- a/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java +++ b/hypertrace-graphql-span-processing-schema/src/main/java/org/hypertrace/graphql/spanprocessing/schema/rule/filter/SpanProcessingRelationalFilter.java @@ -18,7 +18,7 @@ public interface SpanProcessingRelationalFilter { @GraphQLField @GraphQLName(SPAN_PROCESSING_FILTER_KEY_KEY) @GraphQLDescription( - "Span processing filter key is the span attribute provided as string like http.request.body.email") + "Span processing filter key is the span attribute provided as string like http.request.header.authorization") String key(); @GraphQLField