refactor: replace []byte(fmt.Sprintf) with fmt.Appendf (#5209)

findnature · web-flow · commit 0381bc7e9d9a · 2025-05-02T11:22:35.000+03:00
Signed-off-by: findnature &lt;cricis@aliyun.com&gt;
diff --git a/common/policies/policy_test.go b/common/policies/policy_test.go
@@ -202,7 +202,7 @@ func TestPrincipalUniqueSet(t *testing.T) {
 	addPrincipal := func(i int) {
 		principalSet = append(principalSet, &msp.MSPPrincipal{
 			PrincipalClassification: msp.MSPPrincipal_Classification(i),
-			Principal:               []byte(fmt.Sprintf("%d", i)),
+			Principal:               fmt.Appendf(nil, "%d", i),
 		})
 	}
 
@@ -234,7 +234,7 @@ func TestPrincipalSetContainingOnly(t *testing.T) {
 		for i := 0; i < 10; i++ {
 			principalSet = append(principalSet, &msp.MSPPrincipal{
 				PrincipalClassification: msp.MSPPrincipal_IDENTITY,
-				Principal:               []byte(fmt.Sprintf("%d", j*10+i)),
+				Principal:               fmt.Appendf(nil, "%d", j*10+i),
 			})
 		}
 		principalSets = append(principalSets, principalSet)
diff --git a/core/ledger/kvledger/benchmark/experiments/util.go b/core/ledger/kvledger/benchmark/experiments/util.go
@@ -90,7 +90,7 @@ func constructJSONValue(keyNumber int, kvSize int) []byte {
 }
 
 func constructValuePrefix(keyNumber int) []byte {
-	return []byte(fmt.Sprintf("%s%09d", "value_", keyNumber))
+	return fmt.Appendf(nil, "%s%09d", "value_", keyNumber)
 }
 
 func verifyValue(keyNumber int, value []byte) bool {
diff --git a/core/ledger/kvledger/kv_ledger_provider_test.go b/core/ledger/kvledger/kv_ledger_provider_test.go
@@ -386,7 +386,7 @@ func TestMultipleLedgerBasicRW(t *testing.T) {
 		ledgers[i] = l
 		txid := util.GenerateUUID()
 		s, _ := l.NewTxSimulator(txid)
-		err = s.SetState("ns", "testKey", []byte(fmt.Sprintf("testValue_%d", i)))
+		err = s.SetState("ns", "testKey", fmt.Appendf(nil, "testValue_%d", i))
 		s.Done()
 		require.NoError(t, err)
 		res, err := s.GetTxSimulationResults()
@@ -414,7 +414,7 @@ func TestMultipleLedgerBasicRW(t *testing.T) {
 		val, err := q.GetState("ns", "testKey")
 		q.Done()
 		require.NoError(t, err)
-		require.Equal(t, []byte(fmt.Sprintf("testValue_%d", i)), val)
+		require.Equal(t, fmt.Appendf(nil, "testValue_%d", i), val)
 		l.Close()
 	}
 }
diff --git a/core/ledger/kvledger/rwset_backward_compatibility_test.go b/core/ledger/kvledger/rwset_backward_compatibility_test.go
@@ -62,7 +62,7 @@ func testGenerateSampleRWSet(t *testing.T) []byte {
 	simulator, err := ledger.NewTxSimulator(txid)
 	require.NoError(t, err)
 	for i := 0; i < 10011; i++ {
-		require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key-%000d", i), []byte(fmt.Sprintf("value-%000d", i))))
+		require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key-%000d", i), fmt.Appendf(nil, "value-%000d", i)))
 	}
 	simulator.Done()
 	simRes, err := simulator.GetTxSimulationResults()
@@ -76,7 +76,7 @@ func testGenerateSampleRWSet(t *testing.T) []byte {
 	require.NoError(t, err)
 	_, err = simulator.GetState("ns1", fmt.Sprintf("key-%000d", 5))
 	require.NoError(t, err)
-	require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key-%000d", 6), []byte(fmt.Sprintf("value-%000d-new", 6))))
+	require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key-%000d", 6), fmt.Appendf(nil, "value-%000d-new", 6)))
 	itr, err := simulator.GetStateRangeScanIterator("ns1", "", "")
 	require.NoError(t, err)
 	numKVs := 0
diff --git a/core/ledger/kvledger/snapshot_mgmt_test.go b/core/ledger/kvledger/snapshot_mgmt_test.go
@@ -366,7 +366,7 @@ func testutilCommitBlocks(t *testing.T, l ledger.PeerLedger, bg *testutil.BlockG
 		txid := util.GenerateUUID()
 		simulator, err := l.NewTxSimulator(txid)
 		require.NoError(t, err)
-		require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key%d", i), []byte(fmt.Sprintf("value%d", i))))
+		require.NoError(t, simulator.SetState("ns1", fmt.Sprintf("key%d", i), fmt.Appendf(nil, "value%d", i)))
 		simulator.Done()
 		require.NoError(t, err)
 		simRes, err := simulator.GetTxSimulationResults()
diff --git a/core/ledger/kvledger/tests/customtx_processor_test.go b/core/ledger/kvledger/tests/customtx_processor_test.go
@@ -53,7 +53,7 @@ func TestReadWriteCustomTxProcessor(t *testing.T) {
 			require.NoError(t, err)
 			require.Equal(t, []byte("value1"), valKey1)
 			valueCounter++
-			return s.SetState("ns", "key1", []byte(fmt.Sprintf("value1_%d", valueCounter)))
+			return s.SetState("ns", "key1", fmt.Appendf(nil, "value1_%d", valueCounter))
 		}
 
 	// block-2 with two post order transactions
diff --git a/core/ledger/kvledger/txmgmt/privacyenabledstate/snapshot_test.go b/core/ledger/kvledger/txmgmt/privacyenabledstate/snapshot_test.go
@@ -50,9 +50,9 @@ func testSnapshot(t *testing.T, env TestEnv) {
 						Key:       fmt.Sprintf("key-%d", i),
 					},
 					VersionedValue: &statedb.VersionedValue{
-						Value:    []byte(fmt.Sprintf("value-for-key-%d-for-%s", i, ns)),
+						Value:    fmt.Appendf(nil, "value-for-key-%d-for-%s", i, ns),
 						Version:  version.NewHeight(1, 1),
-						Metadata: []byte(fmt.Sprintf("metadata-for-key-%d-for-%s", i, ns)),
+						Metadata: fmt.Appendf(nil, "metadata-for-key-%d-for-%s", i, ns),
 					},
 				}
 				sampleData = append(sampleData, sampleKV)
diff --git a/core/ledger/kvledger/txmgmt/privacyenabledstate/types_test.go b/core/ledger/kvledger/txmgmt/privacyenabledstate/types_test.go
@@ -33,7 +33,7 @@ func TestBatch(t *testing.T) {
 		for j := 0; j < 5; j++ {
 			for k := 0; k < 5; k++ {
 				batch.Put(fmt.Sprintf("ns-%d", i), fmt.Sprintf("collection-%d", j), fmt.Sprintf("key-%d", k),
-					[]byte(fmt.Sprintf("value-%d-%d-%d", i, j, k)), v)
+					fmt.Appendf(nil, "value-%d-%d-%d", i, j, k), v)
 			}
 		}
 	}
@@ -43,7 +43,7 @@ func TestBatch(t *testing.T) {
 				vv := batch.Get(fmt.Sprintf("ns-%d", i), fmt.Sprintf("collection-%d", j), fmt.Sprintf("key-%d", k))
 				require.NotNil(t, vv)
 				require.Equal(t,
-					&statedb.VersionedValue{Value: []byte(fmt.Sprintf("value-%d-%d-%d", i, j, k)), Version: v},
+					&statedb.VersionedValue{Value: fmt.Appendf(nil, "value-%d-%d-%d", i, j, k), Version: v},
 					vv)
 			}
 		}
diff --git a/core/ledger/kvledger/txmgmt/pvtstatepurgemgmt/expiry_keeper_test.go b/core/ledger/kvledger/txmgmt/pvtstatepurgemgmt/expiry_keeper_test.go
@@ -88,7 +88,7 @@ func TestExpiryKeeper(t *testing.T) {
 func buildPvtdataKeysForTest(startingEntry int, numEntries int) *PvtdataKeys {
 	pvtdataKeys := newPvtdataKeys()
 	for i := startingEntry; i <= startingEntry+numEntries; i++ {
-		pvtdataKeys.add(fmt.Sprintf("ns-%d", i), fmt.Sprintf("coll-%d", i), fmt.Sprintf("key-%d", i), []byte(fmt.Sprintf("key-%d-hash", i)))
+		pvtdataKeys.add(fmt.Sprintf("ns-%d", i), fmt.Sprintf("coll-%d", i), fmt.Sprintf("key-%d", i), fmt.Appendf(nil, "key-%d-hash", i))
 	}
 	return pvtdataKeys
 }
diff --git a/core/ledger/kvledger/txmgmt/statedb/commontests/test_common.go b/core/ledger/kvledger/txmgmt/statedb/commontests/test_common.go
@@ -1040,7 +1040,7 @@ func TestDataExportImport(
 					},
 					VersionedValue: &statedb.VersionedValue{
 						Version:  version.NewHeight(1, 1),
-						Metadata: []byte(fmt.Sprintf("metadata-for-key-%d-for-%s", i, ns)),
+						Metadata: fmt.Appendf(nil, "metadata-for-key-%d-for-%s", i, ns),
 					},
 				}
 				switch {
@@ -1145,7 +1145,7 @@ func CreateTestData(t *testing.T, db statedb.VersionedDB, ns string, numKeys int
 	expectedKeys := make([]string, numKeys)
 	for i := 0; i < numKeys; i++ {
 		expectedKeys[i] = fmt.Sprintf("key%d", i)
-		vv := statedb.VersionedValue{Value: []byte(fmt.Sprintf("value%d", i)), Version: version.NewHeight(1, uint64(i+1))}
+		vv := statedb.VersionedValue{Value: fmt.Appendf(nil, "value%d", i), Version: version.NewHeight(1, uint64(i+1))}
 		batch.Put(ns, expectedKeys[i], vv.Value, vv.Version)
 	}
 	savePoint := version.NewHeight(1, uint64(numKeys))
diff --git a/core/ledger/kvledger/txmgmt/statedb/statecouchdb/statecouchdb_test.go b/core/ledger/kvledger/txmgmt/statedb/statecouchdb/statecouchdb_test.go
@@ -1565,9 +1565,9 @@ func TestRangeQueryWithInternalLimitAndPageSize(t *testing.T) {
 					Key:       fmt.Sprintf("key-%d", i),
 				},
 				VersionedValue: &statedb.VersionedValue{
-					Value:    []byte(fmt.Sprintf("value-for-key-%d-for-ns1", i)),
+					Value:    fmt.Appendf(nil, "value-for-key-%d-for-ns1", i),
 					Version:  ver,
-					Metadata: []byte(fmt.Sprintf("metadata-for-key-%d-for-ns1", i)),
+					Metadata: fmt.Appendf(nil, "metadata-for-key-%d-for-ns1", i),
 				},
 			}
 			sampleData = append(sampleData, sampleKV)
@@ -1885,13 +1885,13 @@ func TestFullScanIteratorDeterministicJSONOutput(t *testing.T) {
 				},
 				VersionedValue: &statedb.VersionedValue{
 					Version:  ver,
-					Metadata: []byte(fmt.Sprintf("metadata-for-key-%d-for-ns1", i)),
+					Metadata: fmt.Appendf(nil, "metadata-for-key-%d-for-ns1", i),
 				},
 			}
 			if sortedJSON {
-				sampleKV.Value = []byte(fmt.Sprintf(`{"a":0,"b":0,"c":%d}`, i))
+				sampleKV.Value = fmt.Appendf(nil, `{"a":0,"b":0,"c":%d}`, i)
 			} else {
-				sampleKV.Value = []byte(fmt.Sprintf(`{"c":%d,"b":0,"a":0}`, i))
+				sampleKV.Value = fmt.Appendf(nil, `{"c":%d,"b":0,"a":0}`, i)
 			}
 			sampleData = append(sampleData, sampleKV)
 		}
@@ -1950,9 +1950,9 @@ func TestFullScanIteratorSkipInternalKeys(t *testing.T) {
 					Key:       keys[i],
 				},
 				VersionedValue: &statedb.VersionedValue{
-					Value:    []byte(fmt.Sprintf("value-for-%s-for-ns1", keys[i])),
+					Value:    fmt.Appendf(nil, "value-for-%s-for-ns1", keys[i]),
 					Version:  ver,
-					Metadata: []byte(fmt.Sprintf("metadata-for-%s-for-ns1", keys[i])),
+					Metadata: fmt.Appendf(nil, "metadata-for-%s-for-ns1", keys[i]),
 				},
 			}
 			sampleData = append(sampleData, sampleKV)
diff --git a/core/ledger/kvledger/txmgmt/txmgr/txmgr_test.go b/core/ledger/kvledger/txmgmt/txmgr/txmgr_test.go
@@ -668,7 +668,7 @@ func createTestKey(i int) string {
 }
 
 func createTestValue(i int) []byte {
-	return []byte(fmt.Sprintf("value_%03d", i))
+	return fmt.Appendf(nil, "value_%03d", i)
 }
 
 // TestExecuteQuery is only tested on the CouchDB testEnv
diff --git a/core/ledger/pvtdatastorage/store_test.go b/core/ledger/pvtdatastorage/store_test.go
@@ -1771,7 +1771,7 @@ func produceSamplePvtdata(t *testing.T, txNum uint64, nsColls []string) *ledger.
 		nsCollSplit := strings.Split(nsColl, ":")
 		ns := nsCollSplit[0]
 		coll := nsCollSplit[1]
-		builder.AddToPvtAndHashedWriteSet(ns, coll, fmt.Sprintf("key-%s-%s", ns, coll), []byte(fmt.Sprintf("value-%s-%s", ns, coll)))
+		builder.AddToPvtAndHashedWriteSet(ns, coll, fmt.Sprintf("key-%s-%s", ns, coll), fmt.Appendf(nil, "value-%s-%s", ns, coll))
 	}
 	simRes, err := builder.GetTxSimulationResults()
 	require.NoError(t, err)
diff --git a/core/peer/deliverevents_test.go b/core/peer/deliverevents_test.go
@@ -726,7 +726,7 @@ func produceSamplePvtdataOrPanic(txNum uint64, nsColls []string) *ledger.TxPvtDa
 		nsCollSplit := strings.Split(nsColl, ":")
 		ns := nsCollSplit[0]
 		coll := nsCollSplit[1]
-		builder.AddToPvtAndHashedWriteSet(ns, coll, fmt.Sprintf("key-%s-%s", ns, coll), []byte(fmt.Sprintf("value-%s-%s", ns, coll)))
+		builder.AddToPvtAndHashedWriteSet(ns, coll, fmt.Sprintf("key-%s-%s", ns, coll), fmt.Appendf(nil, "value-%s-%s", ns, coll))
 	}
 	simRes, err := builder.GetTxSimulationResults()
 	if err != nil {
diff --git a/discovery/client/client_test.go b/discovery/client/client_test.go
@@ -854,7 +854,7 @@ func (ip *inquireablePolicy) SatisfiedBy() []policies.PrincipalSet {
 }
 
 func peerIdentity(mspID string, i int) api.PeerIdentityInfo {
-	p := []byte(fmt.Sprintf("p%d", i))
+	p := fmt.Appendf(nil, "p%d", i)
 	sID := &msp.SerializedIdentity{
 		Mspid:   mspID,
 		IdBytes: p,
diff --git a/gossip/discovery/discovery_test.go b/gossip/discovery/discovery_test.go
@@ -1426,7 +1426,7 @@ func TestMsgStoreExpirationWithMembershipMessages(t *testing.T) {
 	for i := 0; i < peersNum; i++ {
 		peerToResponse := &NetworkMember{
 			Metadata:         []byte{},
-			PKIid:            []byte(fmt.Sprintf("localhost:%d", 22610+i)),
+			PKIid:            fmt.Appendf(nil, "localhost:%d", 22610+i),
 			Endpoint:         fmt.Sprintf("localhost:%d", 22610+i),
 			InternalEndpoint: fmt.Sprintf("localhost:%d", 22610+i),
 		}
diff --git a/gossip/gossip/certstore_test.go b/gossip/gossip/certstore_test.go
@@ -235,7 +235,7 @@ func TestCertExpiration(t *testing.T) {
 		m := o.(protoext.ReceivedMessage).GetGossipMessage()
 		if protoext.IsPullMsg(m.GossipMessage) && protoext.IsDigestMsg(m.GossipMessage) {
 			for _, dig := range m.GetDataDig().Digests {
-				if bytes.Equal(dig, []byte(fmt.Sprintf("127.0.0.1:%d", port0))) {
+				if bytes.Equal(dig, fmt.Appendf(nil, "127.0.0.1:%d", port0)) {
 					identitiesGotViaPull <- struct{}{}
 				}
 			}
diff --git a/gossip/gossip/channel/channel_test.go b/gossip/gossip/channel/channel_test.go
@@ -638,7 +638,7 @@ func TestChannelMsgStoreEviction(t *testing.T) {
 	// Since we checked the length, it proves that the old blocks were discarded, since we had much more
 	// total blocks overall than our capacity
 	for seq := range lastPullPhase {
-		require.Contains(t, msg.GetDataDig().Digests, []byte(fmt.Sprintf("%d", seq)))
+		require.Contains(t, msg.GetDataDig().Digests, fmt.Appendf(nil, "%d", seq))
 	}
 }
 
diff --git a/gossip/privdata/coordinator_test.go b/gossip/privdata/coordinator_test.go
@@ -99,7 +99,7 @@ func (fc *fetchCall) expectingEndorsers(orgs ...string) *fetchCall {
 		fc.fetcher.expectedEndorsers = make(map[string]struct{})
 	}
 	for _, org := range orgs {
-		sID := &mspproto.SerializedIdentity{Mspid: org, IdBytes: []byte(fmt.Sprintf("p0%s", org))}
+		sID := &mspproto.SerializedIdentity{Mspid: org, IdBytes: fmt.Appendf(nil, "p0%s", org)}
 		b, _ := pb.Marshal(sID)
 		fc.fetcher.expectedEndorsers[string(b)] = struct{}{}
 	}
diff --git a/gossip/privdata/pvtdataprovider_test.go b/gossip/privdata/pvtdataprovider_test.go
@@ -73,7 +73,7 @@ func TestRetrievePvtdata(t *testing.T) {
 	}
 	endorser := protoutil.MarshalOrPanic(&mspproto.SerializedIdentity{
 		Mspid:   identity.GetMSPIdentifier(),
-		IdBytes: []byte(fmt.Sprintf("p0%s", identity.GetMSPIdentifier())),
+		IdBytes: fmt.Appendf(nil, "p0%s", identity.GetMSPIdentifier()),
 	})
 
 	ts := testSupport{
@@ -846,7 +846,7 @@ func TestRetrievePvtdataFailure(t *testing.T) {
 	}
 	endorser := protoutil.MarshalOrPanic(&mspproto.SerializedIdentity{
 		Mspid:   identity.GetMSPIdentifier(),
-		IdBytes: []byte(fmt.Sprintf("p0%s", identity.GetMSPIdentifier())),
+		IdBytes: fmt.Appendf(nil, "p0%s", identity.GetMSPIdentifier()),
 	})
 
 	ts := testSupport{
@@ -906,7 +906,7 @@ func TestRetryFetchFromPeer(t *testing.T) {
 	}
 	endorser := protoutil.MarshalOrPanic(&mspproto.SerializedIdentity{
 		Mspid:   identity.GetMSPIdentifier(),
-		IdBytes: []byte(fmt.Sprintf("p0%s", identity.GetMSPIdentifier())),
+		IdBytes: fmt.Appendf(nil, "p0%s", identity.GetMSPIdentifier()),
 	})
 
 	ts := testSupport{
@@ -999,7 +999,7 @@ func TestSkipPullingAllInvalidTransactions(t *testing.T) {
 	}
 	endorser := protoutil.MarshalOrPanic(&mspproto.SerializedIdentity{
 		Mspid:   identity.GetMSPIdentifier(),
-		IdBytes: []byte(fmt.Sprintf("p0%s", identity.GetMSPIdentifier())),
+		IdBytes: fmt.Appendf(nil, "p0%s", identity.GetMSPIdentifier()),
 	})
 
 	ts := testSupport{
@@ -1099,7 +1099,7 @@ func TestRetrievedPvtdataPurgeBelowHeight(t *testing.T) {
 	}
 	endorser := protoutil.MarshalOrPanic(&mspproto.SerializedIdentity{
 		Mspid:   identity.GetMSPIdentifier(),
-		IdBytes: []byte(fmt.Sprintf("p0%s", identity.GetMSPIdentifier())),
+		IdBytes: fmt.Appendf(nil, "p0%s", identity.GetMSPIdentifier()),
 	})
 
 	ts := testSupport{
diff --git a/gossip/privdata/util.go b/gossip/privdata/util.go
@@ -80,7 +80,7 @@ func (bf *blockFactory) AddTxnWithEndorsement(txID string, nsName string, hash [
 	}
 
 	if org != "" {
-		sID := &msp.SerializedIdentity{Mspid: org, IdBytes: []byte(fmt.Sprintf("p0%s", org))}
+		sID := &msp.SerializedIdentity{Mspid: org, IdBytes: fmt.Appendf(nil, "p0%s", org)}
 		b, _ := proto.Marshal(sID)
 		ccPayload.Action.Endorsements = []*peer.Endorsement{
 			{
diff --git a/integration/raft/cft_test.go b/integration/raft/cft_test.go
@@ -163,7 +163,7 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
 
 			// Create 5000 envelopes to send to the orderer at the same time
 			for i := 0; i < 5000; i++ {
-				envs <- ordererclient.CreateBroadcastEnvelope(network, orderer, "testchannel", []byte(fmt.Sprintf("%d", i)))
+				envs <- ordererclient.CreateBroadcastEnvelope(network, orderer, "testchannel", fmt.Appendf(nil, "%d", i))
 			}
 
 			close(envs)
@@ -186,7 +186,7 @@ var _ = Describe("EndToEnd Crash Fault Tolerance", func() {
 
 			// Create 5000 envelopes to send to the orderer at the same time
 			for i := 0; i < 5000; i++ {
-				envs <- ordererclient.CreateBroadcastEnvelope(network, orderer, "testchannel", []byte(fmt.Sprintf("%d", i)))
+				envs <- ordererclient.CreateBroadcastEnvelope(network, orderer, "testchannel", fmt.Appendf(nil, "%d", i))
 			}
 
 			close(envs)
diff --git a/orderer/common/multichannel/util_test.go b/orderer/common/multichannel/util_test.go
@@ -110,7 +110,7 @@ func makeConfigTx(chainID string, i int) *cb.Envelope {
 	group := protoutil.NewConfigGroup()
 	group.Groups[channelconfig.OrdererGroupKey] = protoutil.NewConfigGroup()
 	group.Groups[channelconfig.OrdererGroupKey].Values[fmt.Sprintf("%d", i)] = &cb.ConfigValue{
-		Value: []byte(fmt.Sprintf("%d", i)),
+		Value: fmt.Appendf(nil, "%d", i),
 	}
 	return makeConfigTxFromConfigUpdateEnvelope(chainID, &cb.ConfigUpdateEnvelope{
 		ConfigUpdate: protoutil.MarshalOrPanic(&cb.ConfigUpdate{
@@ -182,7 +182,7 @@ func makeNormalTx(chainID string, i int) *cb.Envelope {
 			}),
 			SignatureHeader: protoutil.MarshalOrPanic(&cb.SignatureHeader{}),
 		},
-		Data: []byte(fmt.Sprintf("%d", i)),
+		Data: fmt.Appendf(nil, "%d", i),
 	}
 	return &cb.Envelope{
 		Payload: protoutil.MarshalOrPanic(payload),
diff --git a/orderer/consensus/smartbft/verifier_test.go b/orderer/consensus/smartbft/verifier_test.go
@@ -34,7 +34,7 @@ func TestNodeIdentitiesByID(t *testing.T) {
 	m := make(smartbft.NodeIdentitiesByID)
 	for id := uint64(0); id < 4; id++ {
 		m[id] = protoutil.MarshalOrPanic(&msp.SerializedIdentity{
-			IdBytes: []byte(fmt.Sprintf("%d", id)),
+			IdBytes: fmt.Appendf(nil, "%d", id),
 			Mspid:   "OrdererOrg",
 		})
 
@@ -48,7 +48,7 @@ func TestNodeIdentitiesByID(t *testing.T) {
 	}
 
 	_, ok := m.IdentityToID(protoutil.MarshalOrPanic(&msp.SerializedIdentity{
-		IdBytes: []byte(fmt.Sprintf("%d", 4)),
+		IdBytes: fmt.Appendf(nil, "%d", 4),
 		Mspid:   "OrdererOrg",
 	}))
 

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ func constructJSONValue(keyNumber int, kvSize int) []byte {`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`func constructValuePrefix(keyNumber int) []byte {`
`93`		`- return []byte(fmt.Sprintf("%s%09d", "value_", keyNumber))`
	`93`	`+ return fmt.Appendf(nil, "%s%09d", "value_", keyNumber)`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`func verifyValue(keyNumber int, value []byte) bool {`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ func TestReadWriteCustomTxProcessor(t *testing.T) {`
`53`	`53`	`require.NoError(t, err)`
`54`	`54`	`require.Equal(t, []byte("value1"), valKey1)`
`55`	`55`	`valueCounter++`
`56`		`- return s.SetState("ns", "key1", []byte(fmt.Sprintf("value1_%d", valueCounter)))`
	`56`	`+ return s.SetState("ns", "key1", fmt.Appendf(nil, "value1_%d", valueCounter))`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`// block-2 with two post order transactions`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ func TestBatch(t *testing.T) {`
`33`	`33`	`for j := 0; j < 5; j++ {`
`34`	`34`	`for k := 0; k < 5; k++ {`
`35`	`35`	`batch.Put(fmt.Sprintf("ns-%d", i), fmt.Sprintf("collection-%d", j), fmt.Sprintf("key-%d", k),`
`36`		`- []byte(fmt.Sprintf("value-%d-%d-%d", i, j, k)), v)`
	`36`	`+ fmt.Appendf(nil, "value-%d-%d-%d", i, j, k), v)`
`37`	`37`	`}`
`38`	`38`	`}`
`39`	`39`	`}`
`@@ -43,7 +43,7 @@ func TestBatch(t *testing.T) {`
`43`	`43`	`vv := batch.Get(fmt.Sprintf("ns-%d", i), fmt.Sprintf("collection-%d", j), fmt.Sprintf("key-%d", k))`
`44`	`44`	`require.NotNil(t, vv)`
`45`	`45`	`require.Equal(t,`
`46`		`- &statedb.VersionedValue{Value: []byte(fmt.Sprintf("value-%d-%d-%d", i, j, k)), Version: v},`
	`46`	`+ &statedb.VersionedValue{Value: fmt.Appendf(nil, "value-%d-%d-%d", i, j, k), Version: v},`
`47`	`47`	`vv)`
`48`	`48`	`}`
`49`	`49`	`}`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func TestExpiryKeeper(t *testing.T) {`
`88`	`88`	`func buildPvtdataKeysForTest(startingEntry int, numEntries int) *PvtdataKeys {`
`89`	`89`	`pvtdataKeys := newPvtdataKeys()`
`90`	`90`	`for i := startingEntry; i <= startingEntry+numEntries; i++ {`
`91`		`- pvtdataKeys.add(fmt.Sprintf("ns-%d", i), fmt.Sprintf("coll-%d", i), fmt.Sprintf("key-%d", i), []byte(fmt.Sprintf("key-%d-hash", i)))`
	`91`	`+ pvtdataKeys.add(fmt.Sprintf("ns-%d", i), fmt.Sprintf("coll-%d", i), fmt.Sprintf("key-%d", i), fmt.Appendf(nil, "key-%d-hash", i))`
`92`	`92`	`}`
`93`	`93`	`return pvtdataKeys`
`94`	`94`	`}`