Support struct arguments with all optional fields #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bestbeforetoday
force-pushed
the
schema
branch
3 times, most recently
from
432ef81
to
df8e6b8
Compare
Transaction functions with struct argument that have all their fields as
JSON optional causes a parsing error on the chaincode metadata:
components.schemas.Args.required: Array must have at least 1 items
Having no required fields causes the `required` property to be an empty
array. Draft 4 of the JSON schema specification requires string arrays
to contain at least one element, so an error occurs.
This change modifies the JSON description of the ObjectMetata `Required`
property so that it is omitted when empty.
Signed-off-by: Mark S. Lewis <[email protected]>
bestbeforetoday
force-pushed
the
schema
branch
from
df8e6b8
to
ac2850b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction functions with struct argument that have all their fields as JSON optional causes a parsing error on the chaincode metadata:
Having no required fields causes the
requiredproperty to be an empty array. Draft 4 of the JSON schema specification requires string arrays to contain at least one element, so an error occurs.This change modifies the JSON description of the ObjectMetata
Requiredproperty so that it is omitted when empty.Closes #154.