Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor EthStatsService creation of WebSocket #8313

Open
macfarla opened this issue Feb 17, 2025 · 4 comments · May be fixed by #8327
Open

Refactor EthStatsService creation of WebSocket #8313

macfarla opened this issue Feb 17, 2025 · 4 comments · May be fixed by #8327
Assignees
Labels
good first issue Good for newcomers techdebt maintenance, cleanup, refactoring, documentation

Comments

@macfarla
Copy link
Contributor

macfarla commented Feb 17, 2025

Vertx has deprecated HttpClient.webSocket() methods
it's now a separate class - https://vertx.io/docs/guides/vertx-5-migration-guide/

Refactor EthStatsService and EthStatsServiceTest to use the new class

> Task :ethereum:ethstats:compileJava
Note: /workspace/b2/ethereum/ethstats/src/main/java/org/hyperledger/besu/ethstats/EthStatsService.java uses or overrides a deprecated API.

Acceptance criteria:

  • no deprecation warnings when compiling this module
@macfarla macfarla added good first issue Good for newcomers techdebt maintenance, cleanup, refactoring, documentation labels Feb 17, 2025
@vitamin43
Copy link

Hi, I would like to work on this issue. Could you please assign it to me?

@macfarla
Copy link
Contributor Author

go for it @vitamin43 - any questions you can ask on this issue or in our discord https://discord.com/channels/905194001349627914/938504958909747250

@KYash03
Copy link

KYash03 commented Feb 19, 2025

Hi @macfarla - I apologize for the overlap, but I had already started working on this issue before the assignment to @vitamin43. Here's my PR: #8327

@macfarla
Copy link
Contributor Author

Thanks @KYash03 looks promising, someone will review.

@vitamin43 don't want to waste your time - have a look at other good first issues

@macfarla macfarla assigned KYash03 and unassigned vitamin43 Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers techdebt maintenance, cleanup, refactoring, documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants