-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace serde_cbor with ciborium #264
base: main
Are you sure you want to change the base?
Conversation
@marlonbaeten @berendsliedrecht take a look and see if this would work |
Signed-off-by: Marlon Baeten <[email protected]> Signed-off-by: Ry Jones <[email protected]>
The Android builds are currently using Rust 1.67 in order to provide broader device support (Rust 1.68 increased the minimum NDK version: https://blog.rust-lang.org/2023/01/09/android-ndk-update-r25.html). I'm not sure if this is still necessary but it seems to conflict with one of the dependencies of ciborium which requires 1.70. |
It does look to me like the minimum API version only increased to KitKat which is already under 1% of devices, so I'm not sure how necessary this restriction is. Maybe it's for compatibility with other libraries? @berendsliedrecht |
I suggest merging this and bumping the images repo to whatever is new enough. |
There were some issues we encountered without the custom images in quite recent Android APIs, not sure if that will impact it, but would be good to first test it thoroughly. I think it was mainly the NDK version. Berend would know more |
IIRC it was mainly due to rust 1.67+ not working for the Android builds. But I am not too sure anymore if that was because of I see that the CI fails on |
The crate
serde_cbor
is unmaintained and has not received any updates in the last 3 years. The author of serde_cbor proposes ciborium as an alternative.This PR replaces the dependency on
serde_cbor
withciborium
.