Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accountId from the Signer #166

Open
0x009922 opened this issue May 15, 2023 · 0 comments
Open

Remove accountId from the Signer #166

0x009922 opened this issue May 15, 2023 · 0 comments
Labels
enhancement iroha2 package: client Related to Client package(-s)

Comments

@0x009922
Copy link
Contributor

Description

Signer class has accountId field within it. It is located there so that Client can access it.

I think it doesn't make sense. Signer should be constructed only from a key pair, because it is the only one essential part for making signatures.
@0x009922 0x009922 added enhancement iroha2 package: client Related to Client package(-s) labels May 15, 2023
@0x009922 0x009922 self-assigned this May 19, 2023
@0x009922 0x009922 removed their assignment Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement iroha2 package: client Related to Client package(-s)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@0x009922