Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: throw explanatory errors in case of decoding errors #147

Open
0x009922 opened this issue Mar 10, 2023 · 0 comments
Open

Proposal: throw explanatory errors in case of decoding errors #147

0x009922 opened this issue Mar 10, 2023 · 0 comments
Labels
enhancement iroha2 package: client Related to Client package(-s)

Comments

@0x009922
Copy link
Contributor

@iroha2/data-model is built on a particular version of Iroha 2, and there might be compatibility issues with other version of how structures are (de)serialised. It might cause confusing errors like #126.

I propose to wrap places where @iroha2/client makes Torii requests and decodes their responses with code that catches possible decoding errors and prints a meaningful warning with text like "this library targets Iroha 2 version xxx - please ensure that you're communicating with Iroha of the same version".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement iroha2 package: client Related to Client package(-s)
Projects
None yet
Development

No branches or pull requests

1 participant