Feature/stateless validation rules (#1148)

* Introduce new stateless validation rules

Signed-off-by: kamilsa <[email protected]>

Author: kamilsa

irohad/ametsuchi/impl/storage_impl.hpp

@@ -121,62 +121,62 @@ namespace iroha {
      protected:
       const std::string init_ = R"(
 CREATE TABLE IF NOT EXISTS role (
-    role_id character varying(45),
+    role_id character varying(32),
     PRIMARY KEY (role_id)
 );
 CREATE TABLE IF NOT EXISTS domain (
-    domain_id character varying(164),
-    default_role character varying(45) NOT NULL REFERENCES role(role_id),
+    domain_id character varying(255),
+    default_role character varying(32) NOT NULL REFERENCES role(role_id),
     PRIMARY KEY (domain_id)
 );
 CREATE TABLE IF NOT EXISTS signatory (
     public_key bytea NOT NULL,
     PRIMARY KEY (public_key)
 );
 CREATE TABLE IF NOT EXISTS account (
-    account_id character varying(197),
-    domain_id character varying(164) NOT NULL REFERENCES domain,
+    account_id character varying(288),
+    domain_id character varying(255) NOT NULL REFERENCES domain,
     quorum int NOT NULL,
     transaction_count int NOT NULL DEFAULT 0,
     data JSONB,
     PRIMARY KEY (account_id)
 );
 CREATE TABLE IF NOT EXISTS account_has_signatory (
-    account_id character varying(197) NOT NULL REFERENCES account,
+    account_id character varying(288) NOT NULL REFERENCES account,
     public_key bytea NOT NULL REFERENCES signatory,
     PRIMARY KEY (account_id, public_key)
 );
 CREATE TABLE IF NOT EXISTS peer (
     public_key bytea NOT NULL,
-    address character varying(21) NOT NULL UNIQUE,
+    address character varying(261) NOT NULL UNIQUE,
     PRIMARY KEY (public_key)
 );
 CREATE TABLE IF NOT EXISTS asset (
-    asset_id character varying(197),
-    domain_id character varying(164) NOT NULL REFERENCES domain,
+    asset_id character varying(288),
+    domain_id character varying(255) NOT NULL REFERENCES domain,
     precision int NOT NULL,
     data json,
     PRIMARY KEY (asset_id)
 );
 CREATE TABLE IF NOT EXISTS account_has_asset (
-    account_id character varying(197) NOT NULL REFERENCES account,
-    asset_id character varying(197) NOT NULL REFERENCES asset,
+    account_id character varying(288) NOT NULL REFERENCES account,
+    asset_id character varying(288) NOT NULL REFERENCES asset,
     amount decimal NOT NULL,
     PRIMARY KEY (account_id, asset_id)
 );
 CREATE TABLE IF NOT EXISTS role_has_permissions (
-    role_id character varying(45) NOT NULL REFERENCES role,
+    role_id character varying(32) NOT NULL REFERENCES role,
     permission_id character varying(45),
     PRIMARY KEY (role_id, permission_id)
 );
 CREATE TABLE IF NOT EXISTS account_has_roles (
-    account_id character varying(197) NOT NULL REFERENCES account,
-    role_id character varying(45) NOT NULL REFERENCES role,
+    account_id character varying(288) NOT NULL REFERENCES account,
+    role_id character varying(32) NOT NULL REFERENCES role,
     PRIMARY KEY (account_id, role_id)
 );
 CREATE TABLE IF NOT EXISTS account_has_grantable_permissions (
-    permittee_account_id character varying(197) NOT NULL REFERENCES account,
-    account_id character varying(197) NOT NULL REFERENCES account,
+    permittee_account_id character varying(288) NOT NULL REFERENCES account,
+    account_id character varying(288) NOT NULL REFERENCES account,
     permission_id character varying(45),
     PRIMARY KEY (permittee_account_id, account_id, permission_id)
 );

irohad/execution/CMakeLists.txt

@@ -26,7 +26,6 @@ target_link_libraries(command_execution
         ${Boost_LIBRARIES}
         logger
         common_execution
-        validator
         rxcpp
         shared_model_default_builders
         )

irohad/execution/impl/command_executor.cpp

@@ -23,7 +23,6 @@
 #include "interfaces/commands/command.hpp"
 #include "model/permissions.hpp"
 #include "utils/amount_utils.hpp"
-#include "validator/domain_name_validator.hpp"
 
 namespace iroha {
 
@@ -725,56 +724,33 @@ namespace iroha {
       const shared_model::interface::CreateAccount &command,
       ametsuchi::WsvQuery &queries,
       const shared_model::interface::types::AccountIdType &creator_account_id) {
-    return
-        // Name is within some range
-        not command.accountName().empty()
-        // Account must be well-formed (no system symbols)
-        and ::validator::isValidDomainName(command.accountName());
+    return true;
   }
 
   bool CommandValidator::isValid(
       const shared_model::interface::CreateAsset &command,
       ametsuchi::WsvQuery &queries,
       const shared_model::interface::types::AccountIdType &creator_account_id) {
-    return
-        // Name is within some range
-        not command.assetName().empty() && command.assetName().size() < 10 &&
-        // Account must be well-formed (no system symbols)
-        std::all_of(std::begin(command.assetName()),
-                    std::end(command.assetName()),
-                    [](char c) { return std::isalnum(c); });
+    return true;
   }
 
   bool CommandValidator::isValid(
       const shared_model::interface::CreateDomain &command,
       ametsuchi::WsvQuery &queries,
       const shared_model::interface::types::AccountIdType &creator_account_id) {
-    return
-        // Name is within some range
-        not command.domainId().empty() and command.domainId().size() < 10 and
-        // Account must be well-formed (no system symbols)
-        std::all_of(std::begin(command.domainId()),
-                    std::end(command.domainId()),
-                    [](char c) { return std::isalnum(c); });
+    return true;
   }
 
   bool CommandValidator::isValid(
       const shared_model::interface::CreateRole &command,
       ametsuchi::WsvQuery &queries,
       const shared_model::interface::types::AccountIdType &creator_account_id) {
-    auto role_is_a_subset = std::all_of(
+    return std::all_of(
         command.rolePermissions().begin(),
         command.rolePermissions().end(),
         [&queries, &creator_account_id](auto perm) {
           return checkAccountRolePermission(creator_account_id, queries, perm);
         });
-
-    return role_is_a_subset and not command.roleName().empty()
-        and command.roleName().size() < 8 and
-        // Role must be well-formed (no system symbols)
-        std::all_of(std::begin(command.roleName()),
-                    std::end(command.roleName()),
-                    [](char c) { return std::isalnum(c) and islower(c); });
   }
 
   bool CommandValidator::isValid(
@@ -850,10 +826,6 @@ namespace iroha {
       const shared_model::interface::TransferAsset &command,
       ametsuchi::WsvQuery &queries,
       const shared_model::interface::types::AccountIdType &creator_account_id) {
-    if (command.amount().intValue() == 0) {
-      return false;
-    }
-
     auto asset = queries.getAsset(command.assetId());
     if (not asset) {
       return false;