Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report logic may not be able to find the hyperledger caliper logo when new docs are deployed #1647

Open
davidkel opened this issue Oct 29, 2024 · 0 comments
Labels
bug Something isn't working documentation Related to the documentation

Comments

@davidkel
Copy link
Contributor

davidkel commented Oct 29, 2024

packages/caliper-core/lib/manager/report/template/report.html has the following line

<img src="https://caliper.github.io/caliper/assets/img/hyperledger_caliper_logo_color.png" style="width:95%;" alt="">

this may not work anymore even if changed to

<img src="https://hyperledger-caliper.github.io/caliper/assets/img/hyperledger_caliper_logo_color.png" style="width:95%;" alt="">

When the new docs are published.

So when the new docs are published we should do a quick fix now that references the correct location, but in the future we need a more robust way of getting this image, most likely put the graphic into the caliper-core reports directory and be able to reference it from there.

@davidkel davidkel added the documentation Related to the documentation label Oct 29, 2024
@davidkel davidkel added the bug Something isn't working label Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Related to the documentation
Projects
None yet
Development

No branches or pull requests

1 participant