Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): update publishing workflows to use github.repository_owner #3597

Open
petermetz opened this issue Oct 18, 2024 · 0 comments
Open
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) help wanted Extra attention is needed P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. SPIKE Exploratory work to better scope additional effort
Milestone

Comments

@petermetz
Copy link
Contributor

petermetz commented Oct 18, 2024

Description

This will be part of a hot-fix release where we aim to recover from some of the issues that went wrong with the publishing jobs during the v2.0.0 release.

The root cause of most of the problems is that we've been moved to a new GitHub org which then rendered a lot of the publishing workflows/jobs invalid due them hard-coding the GitHub org as hyperledger instead of using the context variable github.repository_owner [1] [2]

[1] https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/accessing-contextual-information-about-workflow-runs#github-context
[2] https://stackoverflow.com/a/70709545/698470

(add more description and relevant links)

Acceptance Criteria

  1. Publishing workflows have been updated where possible to not hardcode the repository owner as hyperledger
  2. The changes were tested against a 2.0.1-alpha.1 release.
  3. If 2) succeeded then we are good to go. If it did not produce the expected release artifacts then iterate with 2.0.1-alpha.2, 2.0.1-alpha.3, etc. until we get it all hammered out.

@VRamakrishna @sandeepnRES

@petermetz petermetz added bug Something isn't working help wanted Extra attention is needed SPIKE Exploratory work to better scope additional effort Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) P1 Priority 1: Highest labels Oct 18, 2024
@petermetz petermetz added this to the v2.0.1 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Flaky-Test-Automation Issues related to test stability (which is a long running issue that can never fully be solved) help wanted Extra attention is needed P1 Priority 1: Highest Significant_Change Applying this label triggers the more stringent review of the maintainers and the 2+1 PR rule. SPIKE Exploratory work to better scope additional effort
Projects
None yet
Development

No branches or pull requests

1 participant