Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fabric): jestify test cases #3547

Open
jagpreetsinghsasan opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3582
Open

test(fabric): jestify test cases #3547

jagpreetsinghsasan opened this issue Sep 19, 2024 · 3 comments · May be fixed by #3582
Assignees
Labels
enhancement New feature or request Fabric good-first-issue-200-intermediate Jestify For test cases that have been converted from tape to jest P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.

Comments

@jagpreetsinghsasan
Copy link
Contributor

Description

As a developer, I want to jestify the existing fabric connector test cases.
** For this, first make sure that the test which is being converted to use Jest, actually runs.

Acceptance Criteria

  1. Create a task to fix the failing tap test cases
  2. Create a PR for the converted test cases (to Jest)
@jagpreetsinghsasan jagpreetsinghsasan added enhancement New feature or request Fabric good-first-issue-200-intermediate Tests Anything related to tests be that automatic or manual, integration or unit, etc. P3 Priority 3: Medium Jestify For test cases that have been converted from tape to jest labels Sep 19, 2024
@petermetz
Copy link
Contributor

@jagpreetsinghsasan Please make sure to include all the exact paths for the test cases that are being worked on as they are seen in the .taprc file.

Reason: I also randomly pick test cases to migrate from the .taprc file when I have some limited time to work on the smaller things and the way I make sure that there is no duplicate effort is that I do a search in the issue tracker with the path of whatever test case I picked from .taprc and see if any hits come up and if yes, then I know someone else is working on that specific test case migration and I should not touch it. With this issue though, my search would come up as false negative and we would both work on it.

@jagpreetsinghsasan
Copy link
Contributor Author

@petermetz we are covering all the test cases present, which can be moved to jest, so I havent pointed out the specific ones.
@adrianbatuto can you list down the test case names here, for reference?

@adrianbatuto
Copy link
Contributor

These are the tests that are part of this ticket.

packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/deploy-cc-from-golang-source.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/deploy-cc-from-javascript-source.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/deploy-cc-from-typescript-source.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/openapi/openapi-validation-go.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/openapi/openapi-validation.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/unit/identity-internal-crypto-utils.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/obtain-profiles.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-with-identities.test.ts
packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/identity-client.test.ts

@adrianbatuto adrianbatuto linked a pull request Oct 10, 2024 that will close this issue
5 tasks
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 10, 2024
test(fabric): jestify test cases
```
Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js
```
Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 10, 2024
test(fabric): jestify test cases
```
Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js
```
Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 10, 2024
Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
ryjones pushed a commit to adrianbatuto/cacti that referenced this issue Oct 10, 2024
Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 11, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin, excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 11, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin,
excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 14, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin,
excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 14, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin,
excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 23, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin,
excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
adrianbatuto added a commit to adrianbatuto/cacti that referenced this issue Oct 28, 2024
Primary Changes
----------------
1. Jestified remaining tests for the connector-fabric plugin,
excluding add-orgs.test.ts (currently skipped).
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fabric good-first-issue-200-intermediate Jestify For test cases that have been converted from tape to jest P3 Priority 3: Medium Tests Anything related to tests be that automatic or manual, integration or unit, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants