Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References of Mumbai causes Widgets to stop working #7

Closed
srph opened this issue May 2, 2024 · 1 comment
Closed

References of Mumbai causes Widgets to stop working #7

srph opened this issue May 2, 2024 · 1 comment
Assignees

Comments

@srph
Copy link

srph commented May 2, 2024

I recently clean-installed our hyperlane-warp-template fork (this meant removing caches and package-lock), and I found that @hyperlane-xyz/widgets, specifically ChainLogo crashes because it has references to Mumbai which seems to have been removed in https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3521/files. I'm not sure how the sdk generates the Chains constant (I couldn't find it)

On this line, this project references Chains.mumbai which I can't find when inspecting my node_modules folder.

This is what my package.json looks like:

"@hyperlane-xyz/sdk": "^3.8.1",
"@hyperlane-xyz/utils": "^3.8.1",
"@hyperlane-xyz/widgets": "^3.8.0",

From my understanding, ^ installs any minor patches. This means, I'm installing sdk and utils 3.10.0 which have breaking changes for this project.

@jmrossy
Copy link
Collaborator

jmrossy commented May 16, 2024

Hi @srph, sorry I didn't see this sooner.

You're entirely correct! The missing chain was indeed the cause of your error and the recent changes haven't properly observed semantic versioning, sorry.

We're overhauling the way the SDK, CLI, and Widget libs work right now. Instead of having metadata and logos for specific chains baked in, the utilities will take an IRegistry param which they'll use to fetch that kind of data. See here and here.

Thanks for your patience as we make the transition. As for this specific bug, it should be fixed by #8

@jmrossy jmrossy closed this as completed May 16, 2024
@jmrossy jmrossy self-assigned this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants