From 7af3d2de4040060751c1458c8a897d323e87a7f3 Mon Sep 17 00:00:00 2001
From: Tyler Hall <tyler@hyper.io>
Date: Wed, 24 May 2023 01:13:46 -0400
Subject: [PATCH] fix(app-express): only treat getObject as iterable if not
 requesting a signed url

---
 packages/app-express/api/storage.ts | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/packages/app-express/api/storage.ts b/packages/app-express/api/storage.ts
index b27cf471..8f38bac6 100644
--- a/packages/app-express/api/storage.ts
+++ b/packages/app-express/api/storage.ts
@@ -186,8 +186,15 @@ export const storage = (services: HyperServices) => (app: Server) => {
   app.get<NameParams>(
     '/storage/:name/*',
     bindCore(services),
-    ({ params, query, storage }, res) =>
-      fork(
+    ({ params, query, storage }, res) => {
+      /**
+       * If the request is wanting a signedUrl
+       * Then we know the request will be JSON containing the signedUrl
+       * not an iterable
+       */
+      const isIterable = !isTrue(query.useSignedUrl)
+
+      return fork(
         res,
         200,
         storage
@@ -217,8 +224,9 @@ export const storage = (services: HyperServices) => (app: Server) => {
             const readableStream = result
             return readableStream
           }),
-        true,
-      ),
+        isIterable,
+      )
+    },
   )
 
   app.delete(