Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add this app to the popular ToDoMVC collection #5

Open
blokhin opened this issue Nov 8, 2023 · 5 comments
Open

Add this app to the popular ToDoMVC collection #5

blokhin opened this issue Nov 8, 2023 · 5 comments

Comments

@blokhin
Copy link
Contributor

blokhin commented Nov 8, 2023

https://github.com/tastejs/todomvc
@nin-jin
Copy link
Member

nin-jin commented Dec 13, 2023

tastejs/todomvc#2134

@blokhin
Copy link
Contributor Author

blokhin commented Dec 13, 2023

@nin-jin OK, I can say why your PR is not accepted. First, 111 files changed. Second, other than English language is used. Third, there are too many unnecessary files and examples which are not within the scope of PR.

@blokhin
Copy link
Contributor Author

blokhin commented Dec 13, 2023

I will try to do it myself as soon as I have a little bit of time.

@nin-jin
Copy link
Member

nin-jin commented Dec 14, 2023

Изначально там было мало изменений, но 3 года автор ничего не мёржил вообще: https://github.com/tastejs/todomvc/pulls

@blokhin
Copy link
Contributor Author

blokhin commented Dec 14, 2023

Да нет же, за последние месяцы куча принятых PR-ов, переключись на вкладку Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blokhin @nin-jin