Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError when setting ExceptionDictTransformer's constructor arguments locals_max_string and locals_max_length to None #672

Open
Sh4pe opened this issue Nov 13, 2024 · 0 comments · May be fixed by #675
Open

TypeError when setting ExceptionDictTransformer's constructor arguments locals_max_string and locals_max_length to None #672

Sh4pe opened this issue Nov 13, 2024 · 0 comments · May be fixed by #675

Comments

@Sh4pe
Copy link

Sh4pe commented Nov 13, 2024

As of version 24.3.0 (see #627), ExceptionDictTransformer interprets the constructor arguments locals_max_string and locals_max_length as type int | None where None supposedly disables abbreviation or truncation. However, if you set one of those to None, you get a TypeError:

TypeError: '<' not supported between instances of 'NoneType' and 'int'

This is because of the following snippet:

structlog/src/structlog/tracebacks.py

Lines 385 to 390 in 51641b7

if locals_max_length < 0:
msg = f'"locals_max_length" must be >= 0: {locals_max_length}'
raise ValueError(msg)
if locals_max_string < 0:
msg = f'"locals_max_string" must be >= 0: {locals_max_string}'
raise ValueError(msg)

It should contain logic that handles the None case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure locals_max_{length,string} work as expected in case they are None Sh4pe/structlog
1 participant
@Sh4pe