Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an effect by voice #40

Closed
wants to merge 1 commit into from
Closed

Conversation

giann
Copy link

@giann giann commented May 29, 2019

Resolves #39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)

Resolves hundredrabbits#39

To change effect for a voice: <voice number><effect name><value>
If the effect is different than the current one, it's replaced (current
one is disconnected and replaced by the new effect)
@giann
Copy link
Author

giann commented May 29, 2019

If all those additional effects have a performance impact: we can only initialize them when activated by the user.

@giann
Copy link
Author

giann commented Jun 3, 2019

@neauoire did you get a chance to look at it?

@neauoire
Copy link
Member

neauoire commented Jun 3, 2019

It's quite an involved PR, I have pulled it but not tested it too much yet, give me a few more days. I'm leaving for Amsterdam tonight and I'll be back in a week, I'll merge it then :)

@giann giann closed this Nov 6, 2019
@baitcode
Copy link

baitcode commented May 25, 2020

Hello, everyone. Sorry for pulling this up. Did it ever get to master? If not, then what was the problem?

@neauoire
Copy link
Member

I haven't because I'm waiting for one of the school program using Pilot to end(in June), I assured the teacher that I wouldn't change it "too much" until then.

@plungepool
Copy link

Hey there, sorry to bump, started using Orca with Pilot and started thinking about fx per channel and wondered if anyone was working on it. Would love to see this merged to master!

@Kyle-Shanks
Copy link
Contributor

@cyclopssound
I made a knock-off version of pilot that addresses per channel effects and presets and things if you're interested
https://github.com/Kyle-Shanks/Aeronaut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Per voice FX ?
5 participants